build: Remove outdated comment about -ffile-prefix-map
What the developer wrote
Authored by MarcoFalke
build: Remove outdated comment about -ffile-prefix-map
The -ffile-prefix-map option is no longer used and it seems fine to
remove the warning about it possibly breaking coverage builds.
If this needs documentation, the dev notes seem like a better place,
because it also affects other places, such as depends. C.f. commit
407062f2ac93624f350e9e8a4f641c882a2aaf2f
What changed, and why it matters
This commit simply deletes an outdated comment from a build configuration file. No code, compiler flags, or security behavior is changed. It is a documentation cleanup with no security relevance.
No action required; this is a non-functional comment cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes a five-line comment in CMakeLists.txt that warned against using -ffile-prefix-map because of side effects on coverage/profile prefix maps. The actual compiler flag usage is unchanged (-fmacro-prefix-map remains). There are no functional or build-system modifications.
Changed components
CMakeLists.txt (build configuration comment only)Inspect captured patch +0 / −5
diff --git a/CMakeLists.txt b/CMakeLists.txt
index eb27f989..005b1074 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -483,11 +483,6 @@ configure_file(contrib/filter-lcov.py filter-lcov.py USE_SOURCE_PERMISSIONS COPY
# Don't allow extended (non-ASCII) symbols in identifiers. This is easier for code review.
try_append_cxx_flags("-fno-extended-identifiers" TARGET core_interface SKIP_LINK)
-# Avoiding the `-ffile-prefix-map` compiler option because it implies
-# `-fcoverage-prefix-map` on Clang or `-fprofile-prefix-map` on GCC,
-# which can cause issues with coverage builds, particularly when using
-# Clang in the OSS-Fuzz environment due to its use of other options
-# and a third party script, or with GCC.
# Set `-fmacro-prefix-map`, so that source file names are expanded without the
# src prefix.
try_append_cxx_flags("-fmacro-prefix-map=A=B" TARGET core_interface SKIP_LINK
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.