test: Allow --usecli in tests that already support it
What the developer wrote
Authored by MarcoFalke
test: Allow --usecli in tests that already support it
What changed, and why it matters
This commit only changes Bitcoin Core's internal test scripts. It removes five lines that previously told the test framework these particular tests cannot be run with the command-line bitcoin-cli tool. There is no change to the actual Bitcoin node software, no security fix, and no vulnerability.
No action required. This is a benign test-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes self.supports_cli = False from five functional test files. This flag is used by the test framework to decide whether a test can be executed with the --usecli option, which makes the tests issue RPC calls through bitcoin-cli instead of the Python RPC client. The tests were already compatible with --usecli; the flag was unnecessarily restrictive. This is a test-only cleanup/enhancement with no effect on production code.
Changed components
test/functional/feature_coinstatsindex_compatibility.pytest/functional/interface_http.pytest/functional/interface_rest.pytest/functional/rpc_whitelist.pytest/functional/wallet_txn_clone.pyInspect captured patch +0 / −5
diff --git a/test/functional/feature_coinstatsindex_compatibility.py b/test/functional/feature_coinstatsindex_compatibility.py
index 855dc74d..21496a9c 100755
--- a/test/functional/feature_coinstatsindex_compatibility.py
+++ b/test/functional/feature_coinstatsindex_compatibility.py
@@ -16,7 +16,6 @@ from test_framework.util import assert_equal
class CoinStatsIndexTest(BitcoinTestFramework):
def set_test_params(self):
self.num_nodes = 2
- self.supports_cli = False
self.extra_args = [["-coinstatsindex"],["-coinstatsindex"]]
def skip_test_if_missing_module(self):
diff --git a/test/functional/interface_http.py b/test/functional/interface_http.py
index cfa111b7..51a3a653 100755
--- a/test/functional/interface_http.py
+++ b/test/functional/interface_http.py
@@ -95,7 +95,6 @@ class BitcoinHTTPConnection:
class HTTPBasicsTest (BitcoinTestFramework):
def set_test_params(self):
self.num_nodes = 1
- self.supports_cli = False
def setup_network(self):
self.setup_nodes()
diff --git a/test/functional/interface_rest.py b/test/functional/interface_rest.py
index 2009752c..07b42e6b 100755
--- a/test/functional/interface_rest.py
+++ b/test/functional/interface_rest.py
@@ -55,7 +55,6 @@ class RESTTest (BitcoinTestFramework):
self.extra_args = [["-rest", "-blockfilterindex=1"], []]
# whitelist peers to speed up tx relay / mempool sync
self.noban_tx_relay = True
- self.supports_cli = False
def test_rest_request(
self,
diff --git a/test/functional/rpc_whitelist.py b/test/functional/rpc_whitelist.py
index da63b76d..e14a591b 100755
--- a/test/functional/rpc_whitelist.py
+++ b/test/functional/rpc_whitelist.py
@@ -33,7 +33,6 @@ class RPCWhitelistTest(BitcoinTestFramework):
def set_test_params(self):
self.num_nodes = 1
- self.supports_cli = False
def run_test(self):
# 0 => Username
diff --git a/test/functional/wallet_txn_clone.py b/test/functional/wallet_txn_clone.py
index de9fe17f..f4ca1071 100755
--- a/test/functional/wallet_txn_clone.py
+++ b/test/functional/wallet_txn_clone.py
@@ -17,7 +17,6 @@ from test_framework.messages import (
class TxnMallTest(BitcoinTestFramework):
def set_test_params(self):
self.num_nodes = 3
- self.supports_cli = False
self.extra_args = [[] for i in range(self.num_nodes)]
def skip_test_if_missing_module(self):
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.