AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36036: build: Bump clang minimum supported version to 19

Public commit record

What the developer wrote

Authored by Hennadii Stepanov

81/100 · Strong
Merge bitcoin/bitcoin#36036: build: Bump clang minimum supported version to 19

fa8c3c014d1eb17c69a7a286b121134a1c310e54 refactor: Remove unused include for clang-cl on Windows (MarcoFalke)
faffaeb2b66ea3573b8a37bda0154822a216c1d7 build: Drop unused clang-17 -Wno-c++23-extensions workaround (MarcoFalke)
fa31e2595569ad2c6f0f61401917ca6b42a3b45b refactor: Drop unused libc++-16 workarounds (MarcoFalke)
fa6299f87a27853a170be49b67e6e319d244928e clang-format: Use Standard: Latest (MarcoFalke)
fa909de36f3b44d3fd531a3f2f68662b0a37c718 build: Bump clang minimum supported version to 19 (MarcoFalke)

Pull request description:

Most supported operating systems ship with clang-19 (or later), so bump the minimum to that and allow new code to drop workarounds for previous clang bugs.

(For this bump, only C++20 CTAD will become available.)

This patch will only be released in version 33.x, next year (2027).

For reference:

* https://packages.debian.org/bookworm/clang-22
* https://packages.ubuntu.com/noble/clang-20
* CentOS-like 8/9/10 ship clang-21 via Stream
* Free/Open/Net*BSD ship clang-19
* OpenSuse Tumbleweed ships with https://software.opensuse.org/package/clang (clang22); leap:latest with clang-19
* macOS 14: depends/release cross-builds are unaffected and use clang-19
* macOS 14: Native builds use llvm-19-ish via XCode CLT 26.3 since https://github.com/bitcoin/bitcoin/pull/36287
* Windows: VS ships Clang 22

On operating systems where the minimum Clang version is not shipped by default, the user would have to use GCC, or install Clang in a different way. For example:

* https://packages.debian.org/bookworm/g++ (g++-12)
* https://packages.ubuntu.com/jammy/g++-12
* https://apt.llvm.org/, brew, nix, guix, or compile clang from source, ...

ACKs for top commit:
fanquake:
utACK fa8c3c014d1eb17c69a7a286b121134a1c310e54
hebasto:
re-ACK fa8c3c014d1eb17c69a7a286b121134a1c310e54, rebased and removed `-Wno-c++23-extensions` since my last [review](https://github.com/bitcoin/bitcoin/pull/36036#pullrequestreview-5777417373).

Tree-SHA512: 519f018f6b7f7f1a50e72f0f0ba53f60209ebd8a613a973cf0b91638e1bc732c1084b3a6c63cc30c4f0b8b5991d76adde24752e20cd4aead942450a1a8879c68
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit raises the minimum supported version of the Clang compiler used to build Bitcoin Core from version 17 to version 19. It also removes some old workarounds that were only needed for older compiler versions. There is no change to how Bitcoin Core processes transactions, network messages, wallets, or consensus rules. It is a routine build-system maintenance change.

Recommended action

No security action required. Builders and CI maintainers should ensure Clang 19 or later (or GCC 12.1 or later) is available for builds targeting this branch.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.