refactor: Remove trailing semicolon after ADD_SIGNALS_DECL_WRAPPER
What the developer wrote
Authored by MarcoFalke
refactor: Remove trailing semicolon after ADD_SIGNALS_DECL_WRAPPER
This is redundant and inconsistent, because call-sites are expected to
add the semicolon, which they all do.
What changed, and why it matters
This is a minor code cleanup that removes an extra semicolon inside a macro definition. The macro is used to declare signal-handling functions in Bitcoin Core's user-interface layer. All places that use the macro already add their own semicolon, so the one inside the macro was redundant. There is no security or functional change.
No action needed. Treat as normal code maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit edits src/node/interface_ui.h, changing the ADD_SIGNALS_DECL_WRAPPER macro so that the generated signal_name##_connect declaration no longer ends with a semicolon. Because every invocation of the macro already terminates with a semicolon, the previous trailing semicolon produced an empty statement but did not change behavior. This is a pure style/refactoring change with no runtime effect.
Changed components
src/node/interface_ui.hInspect captured patch +1 / −1
diff --git a/src/node/interface_ui.h b/src/node/interface_ui.h
index 2165402f..fe937fc7 100644
--- a/src/node/interface_ui.h
+++ b/src/node/interface_ui.h
@@ -71,7 +71,7 @@ public:
#define ADD_SIGNALS_DECL_WRAPPER(signal_name, rtype, ...) \
rtype signal_name(__VA_ARGS__); \
using signal_name##Sig = rtype(__VA_ARGS__); \
- boost::signals2::connection signal_name##_connect(std::function<signal_name##Sig> fn);
+ boost::signals2::connection signal_name##_connect(std::function<signal_name##Sig> fn)
/** Show message box. */
ADD_SIGNALS_DECL_WRAPPER(ThreadSafeMessageBox, bool, const bilingual_str& message, const std::string& caption, unsigned int style);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.