iwyu: Remove workaround for issue that has been fixed upstream
What the developer wrote
Authored by Hennadii Stepanov
iwyu: Remove workaround for issue that has been fixed upstream
This was overlooked in bitcoin/bitcoin#34896.
What changed, and why it matters
This commit removes a code comment and a special compiler/tooling directive that were only there to work around a bug in a third-party developer tool (include-what-you-use). The actual C++ source code still includes the same header file as before, so program behavior is unchanged. There is no security relevance.
No security action needed. This is a routine code-quality cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes an explanatory comment and the ‘IWYU pragma: keep’ annotation on the ‘#include
Changed components
src/core_io.cppInspect captured patch +1 / −4
diff --git a/src/core_io.cpp b/src/core_io.cpp
index 7492e9ca..7ee0aa8e 100644
--- a/src/core_io.cpp
+++ b/src/core_io.cpp
@@ -11,10 +11,7 @@
#include <consensus/validation.h>
#include <crypto/hex_base.h>
#include <key_io.h>
-// IWYU incorrectly suggests replacing this header
-// with forward declarations.
-// See https://github.com/include-what-you-use/include-what-you-use/issues/1886.
-#include <primitives/block.h> // IWYU pragma: keep
+#include <primitives/block.h>
#include <primitives/transaction.h>
#include <script/descriptor.h>
#include <script/interpreter.h>
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.