AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36618: test: Wait for index sync in all tests

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36618: test: Wait for index sync in all tests

fa74dc72d942e1628cea3c143bb56eed1457bbce test: refactor: Wait for index sync by default (MarcoFalke)
fa8009ba2997a0eb3e6e1a657db507e5a8b8b529 test: Wait for index sync in wallet_fast_rescan.py (MarcoFalke)

Pull request description:

Fixes https://github.com/bitcoin/bitcoin/issues/36564 by adding the missing wait on the index sync.

Diff to reproduce:

```diff
diff --git a/src/util/thread.cpp b/src/util/thread.cpp
index 5b20e807b4..2e988c9eea 100644
--- a/src/util/thread.cpp
+++ b/src/util/thread.cpp
@@ -8,2 +8,3 @@
#include <util/log.h>
+#include <util/time.h>
#include <util/threadnames.h>
@@ -17,2 +18,3 @@ void util::TraceThread(std::string_view thread_name, std::function<void()> threa
util::ThreadRename(std::string{thread_name});
+ UninterruptibleSleep(999ms);
try {
```

Command to reproduce (run twice to create the cache the first time, and reproduce on the second):

```
./bld-cmake/test/functional/wallet_fast_rescan.py | grep WARNING
```

On failure, the log will say something like:

```
- 2026-10-18T05:06:44.451973Z [http.01] [wallet/scan.cpp:142] [ShouldFetchBlock] [scan] Fast rescan: inspect block 200 [4c063a93914ec0cb1604297f2f601dab9b9342bf073e6b80e1c11efd71714e2e] (WARNING: block filter not found!)

ACKs for top commit:
ViniciusCestarii:
ACK fa74dc72d942e1628cea3c143bb56eed1457bbce
hebasto:
ACK fa74dc72d942e1628cea3c143bb56eed1457bbce, the changes are correct.

Tree-SHA512: 750ca9c666f0195fd7781800abf43aea9465af722230ed01e12c3fbd98d795be985a558d061d73446d9ffddd10fa67172d1f1bbc9b9cac87a2899682ff95418b
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit only changes Bitcoin Core's internal functional test framework. It makes the test harness automatically wait for optional indexes (like transaction index, block filter index, and coin stats index) to finish syncing before continuing tests. It does not change the production Bitcoin node software that users run, so it cannot directly affect real wallets, funds, or network security.

Recommended action

No security action needed. This is a test-only reliability improvement. Reviewers may verify that the new default wait behavior does not hide real product bugs or excessively slow CI, but that is a testing quality concern, not a security issue.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.