What the developer wrote
Authored by Hennadii Stepanov
iwyu: Add missed line to IWYU patch
This makes IWYU suggest `<cassert>` over `<assert.h>`.
What changed, and why it matters
This is a tiny maintenance patch for a code-style checking tool used in Bitcoin Core's continuous integration. It adds one missing line to a patch file that tells the Include What You Use (IWYU) tool to recommend the C++ header <cassert> instead of the C header <assert.h>. It does not change any Bitcoin Core runtime code, consensus rules, networking, wallet logic, or build outputs. There is no security relevance.
No security action needed. Treat as normal tooling/maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies ci/test/01_iwyu.patch, an IWYU mapping patch used in CI. The change marks
Changed components
ci/test/01_iwyu.patchInspect captured patch +4 / −2
diff --git a/ci/test/01_iwyu.patch b/ci/test/01_iwyu.patch
index e14316bf..e7d75f4e 100644
--- a/ci/test/01_iwyu.patch
+++ b/ci/test/01_iwyu.patch
@@ -539,10 +539,11 @@ See: https://github.com/include-what-you-use/include-what-you-use/blob/clang_21/
};
const IncludeMapEntry stdlib_c_include_map[] = {
-@@ -601,31 +601,31 @@ const IncludeMapEntry stdlib_c_include_map[] = {
+@@ -600,32 +600,32 @@ const IncludeMapEntry stdlib_c_include_map[] = {
+ // https://github.com/cplusplus/draft/blob/c+%2B20/source/lib-intro.tex
//
// $ curl -s -N https://raw.githubusercontent.com/cplusplus/draft/c%2B%2B20/source/lib-intro.tex | sed -n '/begin{multicolfloattable}.*{headers.cpp.c}/,/end{multicolfloattable}/p' | grep tcode | perl -nle 'm/tcode{<c(.*)>}/ && print qq@ { "<$1.h>", kPublic, "<c$1>", kPublic },@' | sort
- { "<assert.h>", kPublic, "<cassert>", kPublic },
+- { "<assert.h>", kPublic, "<cassert>", kPublic },
- { "<complex.h>", kPublic, "<ccomplex>", kPublic },
- { "<ctype.h>", kPublic, "<cctype>", kPublic },
- { "<errno.h>", kPublic, "<cerrno>", kPublic },
@@ -568,6 +569,7 @@ See: https://github.com/include-what-you-use/include-what-you-use/blob/clang_21/
- { "<uchar.h>", kPublic, "<cuchar>", kPublic },
- { "<wchar.h>", kPublic, "<cwchar>", kPublic },
- { "<wctype.h>", kPublic, "<cwctype>", kPublic },
++ { "<assert.h>", kPrivate, "<cassert>", kPublic },
+ { "<complex.h>", kPrivate, "<ccomplex>", kPublic },
+ { "<ctype.h>", kPrivate, "<cctype>", kPublic },
+ { "<errno.h>", kPrivate, "<cerrno>", kPublic },
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.