← Watch feed
test: move and simplify BOOST_CHECK ostream helpers
Public commit record
95/100 · Strong
What the developer wrote
Authored by Hodlinator
test: move and simplify BOOST_CHECK ostream helpers
Move the operator<< overloads used by BOOST_CHECK_* out of the
unit test machinery test/setup_common, into test/util/common.h.
And replace the individual per-type ToString() overloads with
a single concept-constrained template that covers any type
exposing a ToString() method. This is important to not add
uint256.h and transaction_identifier.h dependencies to the
shared test/util/common.h file.
Co-authored-by: furszy <matiasfurszyfer@protonmail.com>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
What changed, and why it matters
This commit is a pure test-code refactoring. It moves helper functions that let Boost test macros print custom Bitcoin types (like transaction IDs and 256-bit numbers) into a shared test header, and replaces several specific helpers with one generic template. It does not change any production code, network behavior, or wallet logic, and it introduces no security fix or vulnerability.
Recommended action
No security action needed. Treat as normal code hygiene / refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change relocates ostream operator<< overloads used by BOOST_CHECK_* from src/test/util/setup_common.h/.cpp into a new src/test/util/common.h. It replaces per-type overloads for arith_uint256, uint160, uint256, Txid, and Wtxid with a single C++20 concept-constrained template (HasToString) that works for any type exposing a ToString() method. The enum and std::optional overloads are also moved. Many test files gain an #include
Changed components
src/test/util/common.h (new)src/test/util/setup_common.hsrc/test/util/setup_common.cppvarious *_tests.cpp files (include changes only)Inspect captured patch +89 / −51
diff --git a/src/test/arith_uint256_tests.cpp b/src/test/arith_uint256_tests.cpp
index 0a154580..016b4658 100644
--- a/src/test/arith_uint256_tests.cpp
+++ b/src/test/arith_uint256_tests.cpp
@@ -3,7 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <arith_uint256.h>
-#include <test/util/setup_common.h>
+#include <test/util/common.h>
#include <uint256.h>
#include <boost/test/unit_test.hpp>
diff --git a/src/test/blockencodings_tests.cpp b/src/test/blockencodings_tests.cpp
index 0fbe0f3c..e4200cac 100644
--- a/src/test/blockencodings_tests.cpp
+++ b/src/test/blockencodings_tests.cpp
@@ -10,6 +10,7 @@
#include <test/util/random.h>
#include <test/util/txmempool.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <boost/test/unit_test.hpp>
diff --git a/src/test/blockfilter_index_tests.cpp b/src/test/blockfilter_index_tests.cpp
index d7d10dfb..25762e07 100644
--- a/src/test/blockfilter_index_tests.cpp
+++ b/src/test/blockfilter_index_tests.cpp
@@ -12,6 +12,7 @@
#include <node/miner.h>
#include <pow.h>
#include <test/util/blockfilter.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <validation.h>
diff --git a/src/test/blockfilter_tests.cpp b/src/test/blockfilter_tests.cpp
index c8334dab..0fc7d5b2 100644
--- a/src/test/blockfilter_tests.cpp
+++ b/src/test/blockfilter_tests.cpp
@@ -3,7 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <test/data/blockfilters.json.h>
-#include <test/util/setup_common.h>
+#include <test/util/common.h>
#include <blockfilter.h>
#include <core_io.h>
diff --git a/src/test/blockmanager_tests.cpp b/src/test/blockmanager_tests.cpp
index f1b6c017..68178dec 100644
--- a/src/test/blockmanager_tests.cpp
+++ b/src/test/blockmanager_tests.cpp
@@ -14,6 +14,7 @@
#include <validation.h>
#include <boost/test/unit_test.hpp>
+#include <test/util/common.h>
#include <test/util/logging.h>
#include <test/util/setup_common.h>
diff --git a/src/test/bloom_tests.cpp b/src/test/bloom_tests.cpp
index 8e02cfd0..ed333c34 100644
--- a/src/test/bloom_tests.cpp
+++ b/src/test/bloom_tests.cpp
@@ -13,6 +13,7 @@
#include <random.h>
#include <serialize.h>
#include <streams.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
#include <uint256.h>
diff --git a/src/test/coins_tests.cpp b/src/test/coins_tests.cpp
index 0b7af376..8321bf6a 100644
--- a/src/test/coins_tests.cpp
+++ b/src/test/coins_tests.cpp
@@ -6,6 +6,7 @@
#include <clientversion.h>
#include <coins.h>
#include <streams.h>
+#include <test/util/common.h>
#include <test/util/poolresourcetester.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
diff --git a/src/test/crypto_tests.cpp b/src/test/crypto_tests.cpp
index 5588d4cd..b348793b 100644
--- a/src/test/crypto_tests.cpp
+++ b/src/test/crypto_tests.cpp
@@ -17,6 +17,7 @@
#include <crypto/muhash.h>
#include <random.h>
#include <streams.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
#include <util/strencodings.h>
diff --git a/src/test/dbwrapper_tests.cpp b/src/test/dbwrapper_tests.cpp
index d3a9e543..3896ea64 100644
--- a/src/test/dbwrapper_tests.cpp
+++ b/src/test/dbwrapper_tests.cpp
@@ -3,6 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <dbwrapper.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
#include <uint256.h>
diff --git a/src/test/getarg_tests.cpp b/src/test/getarg_tests.cpp
index ec17fe39..d349ceea 100644
--- a/src/test/getarg_tests.cpp
+++ b/src/test/getarg_tests.cpp
@@ -5,6 +5,7 @@
#include <common/args.h>
#include <common/settings.h>
#include <logging.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <univalue.h>
#include <util/strencodings.h>
diff --git a/src/test/headers_sync_chainwork_tests.cpp b/src/test/headers_sync_chainwork_tests.cpp
index f9426fa3..bba612f8 100644
--- a/src/test/headers_sync_chainwork_tests.cpp
+++ b/src/test/headers_sync_chainwork_tests.cpp
@@ -8,6 +8,7 @@
#include <headerssync.h>
#include <net_processing.h>
#include <pow.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <validation.h>
diff --git a/src/test/interfaces_tests.cpp b/src/test/interfaces_tests.cpp
index da0f5eec..1a98256c 100644
--- a/src/test/interfaces_tests.cpp
+++ b/src/test/interfaces_tests.cpp
@@ -5,6 +5,7 @@
#include <chainparams.h>
#include <consensus/validation.h>
#include <interfaces/chain.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <script/solver.h>
#include <validation.h>
diff --git a/src/test/key_tests.cpp b/src/test/key_tests.cpp
index acced716..b0c052af 100644
--- a/src/test/key_tests.cpp
+++ b/src/test/key_tests.cpp
@@ -9,6 +9,7 @@
#include <span.h>
#include <streams.h>
#include <secp256k1_extrakeys.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
#include <uint256.h>
diff --git a/src/test/logging_tests.cpp b/src/test/logging_tests.cpp
index 8ead946f..f232bb41 100644
--- a/src/test/logging_tests.cpp
+++ b/src/test/logging_tests.cpp
@@ -6,6 +6,7 @@
#include <logging.h>
#include <logging/timer.h>
#include <scheduler.h>
+#include <test/util/common.h>
#include <test/util/logging.h>
#include <test/util/setup_common.h>
#include <tinyformat.h>
diff --git a/src/test/merkle_tests.cpp b/src/test/merkle_tests.cpp
index dc479141..a7212147 100644
--- a/src/test/merkle_tests.cpp
+++ b/src/test/merkle_tests.cpp
@@ -3,6 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <consensus/merkle.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
diff --git a/src/test/merkleblock_tests.cpp b/src/test/merkleblock_tests.cpp
index 00a1f0b9..a461e043 100644
--- a/src/test/merkleblock_tests.cpp
+++ b/src/test/merkleblock_tests.cpp
@@ -3,6 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <merkleblock.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <uint256.h>
diff --git a/src/test/miner_tests.cpp b/src/test/miner_tests.cpp
index 7f05e4e9..ca170049 100644
--- a/src/test/miner_tests.cpp
+++ b/src/test/miner_tests.cpp
@@ -25,6 +25,7 @@
#include <versionbits.h>
#include <pow.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <memory>
diff --git a/src/test/minisketch_tests.cpp b/src/test/minisketch_tests.cpp
index 1d6f2a12..ba895478 100644
--- a/src/test/minisketch_tests.cpp
+++ b/src/test/minisketch_tests.cpp
@@ -5,6 +5,7 @@
#include <minisketch.h>
#include <node/minisketchwrapper.h>
#include <random.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
diff --git a/src/test/multisig_tests.cpp b/src/test/multisig_tests.cpp
index 932b83fe..0b1cc980 100644
--- a/src/test/multisig_tests.cpp
+++ b/src/test/multisig_tests.cpp
@@ -9,6 +9,7 @@
#include <script/script_error.h>
#include <script/sign.h>
#include <script/signingprovider.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <test/util/transaction_utils.h>
#include <tinyformat.h>
diff --git a/src/test/netbase_tests.cpp b/src/test/netbase_tests.cpp
index 4770cabf..e376b0cf 100644
--- a/src/test/netbase_tests.cpp
+++ b/src/test/netbase_tests.cpp
@@ -10,6 +10,7 @@
#include <protocol.h>
#include <serialize.h>
#include <streams.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <util/strencodings.h>
#include <util/translation.h>
diff --git a/src/test/node_init_tests.cpp b/src/test/node_init_tests.cpp
index a4292e66..44635dd4 100644
--- a/src/test/node_init_tests.cpp
+++ b/src/test/node_init_tests.cpp
@@ -7,6 +7,7 @@
#include <rpc/server.h>
#include <boost/test/unit_test.hpp>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
using node::NodeContext;
diff --git a/src/test/orphanage_tests.cpp b/src/test/orphanage_tests.cpp
index 933736dc..6ebfab34 100644
--- a/src/test/orphanage_tests.cpp
+++ b/src/test/orphanage_tests.cpp
@@ -10,6 +10,7 @@
#include <pubkey.h>
#include <script/sign.h>
#include <script/signingprovider.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
#include <test/util/transaction_utils.h>
diff --git a/src/test/pcp_tests.cpp b/src/test/pcp_tests.cpp
index c71c9de1..51b004a5 100644
--- a/src/test/pcp_tests.cpp
+++ b/src/test/pcp_tests.cpp
@@ -5,6 +5,7 @@
#include <common/pcp.h>
#include <netbase.h>
#include <test/util/logging.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <util/time.h>
diff --git a/src/test/pow_tests.cpp b/src/test/pow_tests.cpp
index 8de76ff2..f6123401 100644
--- a/src/test/pow_tests.cpp
+++ b/src/test/pow_tests.cpp
@@ -6,6 +6,7 @@
#include <chainparams.h>
#include <pow.h>
#include <test/util/random.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <util/chaintype.h>
diff --git a/src/test/rest_tests.cpp b/src/test/rest_tests.cpp
index 5dc12250..fefc41bd 100644
--- a/src/test/rest_tests.cpp
+++ b/src/test/rest_tests.cpp
@@ -3,6 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <rest.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <boost/test/unit_test.hpp>
diff --git a/src/test/rpc_tests.cpp b/src/test/rpc_tests.cpp
index f8d75a80..b435fb89 100644
--- a/src/test/rpc_tests.cpp
+++ b/src/test/rpc_tests.cpp
@@ -9,6 +9,7 @@
#include <rpc/client.h>
#include <rpc/server.h>
#include <rpc/util.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <univalue.h>
#include <util/time.h>
diff --git a/src/test/script_standard_tests.cpp b/src/test/script_standard_tests.cpp
index c6d3b125..a1e0c46a 100644
--- a/src/test/script_standard_tests.cpp
+++ b/src/test/script_standard_tests.cpp
@@ -10,6 +10,7 @@
#include <script/script.h>
#include <script/signingprovider.h>
#include <script/solver.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <util/strencodings.h>
diff --git a/src/test/script_tests.cpp b/src/test/script_tests.cpp
index 2134bcc1..1478cf91 100644
--- a/src/test/script_tests.cpp
+++ b/src/test/script_tests.cpp
@@ -19,6 +19,7 @@
#include <streams.h>
#include <test/util/json.h>
#include <test/util/random.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <test/util/transaction_utils.h>
#include <util/fs.h>
@@ -26,7 +27,6 @@
#include <util/string.h>
#include <cstdint>
-#include <fstream>
#include <string>
#include <vector>
diff --git a/src/test/serialize_tests.cpp b/src/test/serialize_tests.cpp
index 33a9133d..f646ba5f 100644
--- a/src/test/serialize_tests.cpp
+++ b/src/test/serialize_tests.cpp
@@ -5,6 +5,7 @@
#include <hash.h>
#include <serialize.h>
#include <streams.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <util/strencodings.h>
diff --git a/src/test/sighash_tests.cpp b/src/test/sighash_tests.cpp
index 5d65c35a..5afdea43 100644
--- a/src/test/sighash_tests.cpp
+++ b/src/test/sighash_tests.cpp
@@ -11,6 +11,7 @@
#include <serialize.h>
#include <streams.h>
#include <test/data/sighash.json.h>
+#include <test/util/common.h>
#include <test/util/json.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
diff --git a/src/test/streams_tests.cpp b/src/test/streams_tests.cpp
index af75ee98..dfddc415 100644
--- a/src/test/streams_tests.cpp
+++ b/src/test/streams_tests.cpp
@@ -5,6 +5,7 @@
#include <flatfile.h>
#include <node/blockstorage.h>
#include <streams.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
#include <util/fs.h>
diff --git a/src/test/transaction_tests.cpp b/src/test/transaction_tests.cpp
index e722e724..916f565c 100644
--- a/src/test/transaction_tests.cpp
+++ b/src/test/transaction_tests.cpp
@@ -26,6 +26,7 @@
#include <script/signingprovider.h>
#include <script/solver.h>
#include <streams.h>
+#include <test/util/common.h>
#include <test/util/json.h>
#include <test/util/random.h>
#include <test/util/script.h>
diff --git a/src/test/txdownload_tests.cpp b/src/test/txdownload_tests.cpp
index e9c6160e..d7ddef90 100644
--- a/src/test/txdownload_tests.cpp
+++ b/src/test/txdownload_tests.cpp
@@ -8,6 +8,7 @@
#include <node/txdownloadman_impl.h>
#include <primitives/transaction.h>
#include <script/script.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
#include <validation.h>
diff --git a/src/test/txospenderindex_tests.cpp b/src/test/txospenderindex_tests.cpp
index c54370a5..f890692d 100644
--- a/src/test/txospenderindex_tests.cpp
+++ b/src/test/txospenderindex_tests.cpp
@@ -3,6 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <index/txospenderindex.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <validation.h>
diff --git a/src/test/txpackage_tests.cpp b/src/test/txpackage_tests.cpp
index 24760664..06c5816b 100644
--- a/src/test/txpackage_tests.cpp
+++ b/src/test/txpackage_tests.cpp
@@ -11,6 +11,7 @@
#include <script/script.h>
#include <serialize.h>
#include <streams.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/script.h>
#include <test/util/setup_common.h>
diff --git a/src/test/txreconciliation_tests.cpp b/src/test/txreconciliation_tests.cpp
index d4ed3511..1d0195b6 100644
--- a/src/test/txreconciliation_tests.cpp
+++ b/src/test/txreconciliation_tests.cpp
@@ -4,6 +4,7 @@
#include <node/txreconciliation.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <boost/test/unit_test.hpp>
diff --git a/src/test/txvalidation_tests.cpp b/src/test/txvalidation_tests.cpp
index b16b6047..2a4f213c 100644
--- a/src/test/txvalidation_tests.cpp
+++ b/src/test/txvalidation_tests.cpp
@@ -11,6 +11,7 @@
#include <primitives/transaction.h>
#include <random.h>
#include <script/script.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <test/util/txmempool.h>
#include <validation.h>
diff --git a/src/test/uint256_tests.cpp b/src/test/uint256_tests.cpp
index a4ebc049..0de391d8 100644
--- a/src/test/uint256_tests.cpp
+++ b/src/test/uint256_tests.cpp
@@ -4,7 +4,7 @@
#include <primitives/transaction_identifier.h>
#include <streams.h>
-#include <test/util/setup_common.h>
+#include <test/util/common.h>
#include <uint256.h>
#include <util/strencodings.h>
diff --git a/src/test/util/common.h b/src/test/util/common.h
new file mode 100644
index 00000000..c19c0888
--- /dev/null
+++ b/src/test/util/common.h
@@ -0,0 +1,39 @@
+// Copyright (c) The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or https://www.opensource.org/licenses/mit-license.php.
+
+#ifndef BITCOIN_TEST_UTIL_COMMON_H
+#define BITCOIN_TEST_UTIL_COMMON_H
+
+#include <ostream>
+#include <optional>
+#include <string>
+
+// Make types usable in BOOST_CHECK_* @{
+namespace std {
+template <typename T> requires std::is_enum_v<T>
+inline std::ostream& operator<<(std::ostream& os, const T& e)
+{
+ return os << static_cast<std::underlying_type_t<T>>(e);
+}
+
+template <typename T>
+inline std::ostream& operator<<(std::ostream& os, const std::optional<T>& v)
+{
+ return v ? os << *v
+ : os << "std::nullopt";
+}
+} // namespace std
+
+template <typename T>
+concept HasToString = requires(const T& t) { t.ToString(); };
+
+template <HasToString T>
+inline std::ostream& operator<<(std::ostream& os, const T& obj)
+{
+ return os << obj.ToString();
+}
+
+// @}
+
+#endif // BITCOIN_TEST_UTIL_COMMON_H
diff --git a/src/test/util/setup_common.cpp b/src/test/util/setup_common.cpp
index 995f532f..6fdc9e18 100644
--- a/src/test/util/setup_common.cpp
+++ b/src/test/util/setup_common.cpp
@@ -620,26 +620,3 @@ CBlock getBlock13b8a()
stream >> TX_WITH_WITNESS(block);
return block;
}
-
-std::ostream& operator<<(std::ostream& os, const arith_uint256& num)
-{
- return os << num.ToString();
-}
-
-std::ostream& operator<<(std::ostream& os, const uint160& num)
-{
- return os << num.ToString();
-}
-
-std::ostream& operator<<(std::ostream& os, const uint256& num)
-{
- return os << num.ToString();
-}
-
-std::ostream& operator<<(std::ostream& os, const Txid& txid) {
- return os << txid.ToString();
-}
-
-std::ostream& operator<<(std::ostream& os, const Wtxid& wtxid) {
- return os << wtxid.ToString();
-}
diff --git a/src/test/util/setup_common.h b/src/test/util/setup_common.h
index 05851e41..cc0d7ffd 100644
--- a/src/test/util/setup_common.h
+++ b/src/test/util/setup_common.h
@@ -261,29 +261,6 @@ std::unique_ptr<T> MakeNoLogFileContext(const ChainType chain_type = ChainType::
CBlock getBlock13b8a();
-// Make types usable in BOOST_CHECK_* @{
-namespace std {
-template <typename T> requires std::is_enum_v<T>
-inline std::ostream& operator<<(std::ostream& os, const T& e)
-{
- return os << static_cast<std::underlying_type_t<T>>(e);
-}
-
-template <typename T>
-inline std::ostream& operator<<(std::ostream& os, const std::optional<T>& v)
-{
- return v ? os << *v
- : os << "std::nullopt";
-}
-} // namespace std
-
-std::ostream& operator<<(std::ostream& os, const arith_uint256& num);
-std::ostream& operator<<(std::ostream& os, const uint160& num);
-std::ostream& operator<<(std::ostream& os, const uint256& num);
-std::ostream& operator<<(std::ostream& os, const Txid& txid);
-std::ostream& operator<<(std::ostream& os, const Wtxid& wtxid);
-// @}
-
/**
* BOOST_CHECK_EXCEPTION predicates to check the specific validation error.
* Use as
diff --git a/src/test/util_string_tests.cpp b/src/test/util_string_tests.cpp
index 9f7513fb..ad737ce9 100644
--- a/src/test/util_string_tests.cpp
+++ b/src/test/util_string_tests.cpp
@@ -7,6 +7,7 @@
#include <vector>
#include <boost/test/unit_test.hpp>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
using namespace util;
diff --git a/src/test/util_tests.cpp b/src/test/util_tests.cpp
index 2b4e5330..d8d70d53 100644
--- a/src/test/util_tests.cpp
+++ b/src/test/util_tests.cpp
@@ -9,6 +9,7 @@
#include <script/parsing.h>
#include <span.h>
#include <sync.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
#include <uint256.h>
diff --git a/src/test/validation_block_tests.cpp b/src/test/validation_block_tests.cpp
index f91b30a3..083a32da 100644
--- a/src/test/validation_block_tests.cpp
+++ b/src/test/validation_block_tests.cpp
@@ -10,6 +10,7 @@
#include <node/miner.h>
#include <pow.h>
#include <random.h>
+#include <test/util/common.h>
#include <test/util/random.h>
#include <test/util/script.h>
#include <test/util/setup_common.h>
diff --git a/src/test/validation_chainstate_tests.cpp b/src/test/validation_chainstate_tests.cpp
index a4a81bba..cb3a04ef 100644
--- a/src/test/validation_chainstate_tests.cpp
+++ b/src/test/validation_chainstate_tests.cpp
@@ -11,6 +11,7 @@
#include <script/script.h>
#include <sync.h>
#include <test/util/chainstate.h>
+#include <test/util/common.h>
#include <test/util/coins.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
diff --git a/src/test/validation_chainstatemanager_tests.cpp b/src/test/validation_chainstatemanager_tests.cpp
index 40f99690..06de793d 100644
--- a/src/test/validation_chainstatemanager_tests.cpp
+++ b/src/test/validation_chainstatemanager_tests.cpp
@@ -12,6 +12,7 @@
#include <rpc/blockchain.h>
#include <sync.h>
#include <test/util/chainstate.h>
+#include <test/util/common.h>
#include <test/util/logging.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
diff --git a/src/test/validation_flush_tests.cpp b/src/test/validation_flush_tests.cpp
index 66c284b9..c35cef7f 100644
--- a/src/test/validation_flush_tests.cpp
+++ b/src/test/validation_flush_tests.cpp
@@ -5,6 +5,7 @@
#include <sync.h>
#include <test/util/coins.h>
#include <test/util/random.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <validation.h>
diff --git a/src/test/versionbits_tests.cpp b/src/test/versionbits_tests.cpp
index ea104402..ad792053 100644
--- a/src/test/versionbits_tests.cpp
+++ b/src/test/versionbits_tests.cpp
@@ -6,6 +6,7 @@
#include <chainparams.h>
#include <consensus/params.h>
#include <test/util/random.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <util/chaintype.h>
#include <versionbits.h>
diff --git a/src/wallet/test/coinselector_tests.cpp b/src/wallet/test/coinselector_tests.cpp
index 7f55d765..92a35b08 100644
--- a/src/wallet/test/coinselector_tests.cpp
+++ b/src/wallet/test/coinselector_tests.cpp
@@ -7,6 +7,7 @@
#include <policy/policy.h>
#include <primitives/transaction.h>
#include <random.h>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <util/translation.h>
#include <wallet/coincontrol.h>
diff --git a/src/wallet/test/db_tests.cpp b/src/wallet/test/db_tests.cpp
index 8b71634e..532bdce3 100644
--- a/src/wallet/test/db_tests.cpp
+++ b/src/wallet/test/db_tests.cpp
@@ -4,6 +4,7 @@
#include <boost/test/unit_test.hpp>
+#include <test/util/common.h>
#include <test/util/setup_common.h>
#include <util/check.h>
#include <util/fs.h>
@@ -14,7 +15,6 @@
#include <wallet/walletutil.h>
#include <cstddef>
-#include <fstream>
#include <memory>
#include <span>
#include <string>
diff --git a/src/wallet/test/wallet_tests.cpp b/src/wallet/test/wallet_tests.cpp
index 36782cd1..54f45362 100644
--- a/src/wallet/test/wallet_tests.cpp
+++ b/src/wallet/test/wallet_tests.cpp
@@ -17,6 +17,7 @@
#include <policy/policy.h>
#include <rpc/server.h>
#include <script/solver.h>
+#include <test/util/common.h>
#include <test/util/logging.h>
#include <test/util/random.h>
#include <test/util/setup_common.h>
diff --git a/src/wallet/test/wallet_transaction_tests.cpp b/src/wallet/test/wallet_transaction_tests.cpp
index e4943906..38be52f4 100644
--- a/src/wallet/test/wallet_transaction_tests.cpp
+++ b/src/wallet/test/wallet_transaction_tests.cpp
@@ -4,6 +4,7 @@
#include <wallet/transaction.h>
+#include <test/util/common.h>
#include <wallet/test/wallet_test_fixture.h>
#include <boost/test/unit_test.hpp>
diff --git a/src/wallet/test/walletload_tests.cpp b/src/wallet/test/walletload_tests.cpp
index c380af79..46b0ab16 100644
--- a/src/wallet/test/walletload_tests.cpp
+++ b/src/wallet/test/walletload_tests.cpp
@@ -4,6 +4,7 @@
#include <wallet/test/util.h>
#include <wallet/wallet.h>
+#include <test/util/common.h>
#include <test/util/logging.h>
#include <test/util/setup_common.h>
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.