What changed, and why it matters
This commit only updates documentation and code comments to match a previously merged change (PR 33106). It does not modify any executable network, consensus, wallet, or mempool code, so it has no security impact on its own.
No security action needed. Treat as ordinary documentation/test-comment cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adjusts release notes and two comments in test files. The release-notes file removes an explanatory clause about mempool minimum feerate behavior. miner_tests.cpp rewords a comment about fee rounding in package selection tests. feature_rbf.py corrects a comment from 1000 sat/KB to 100 sat/KB to reflect the new incrementalrelayfee default. No production logic is changed.
Changed components
doc/release-notes-33106.mdsrc/test/miner_tests.cpp (comments only)test/functional/feature_rbf.py (comments only)Inspect captured patch +4 / −4
diff --git a/doc/release-notes-33106.md b/doc/release-notes-33106.md
index 95750ced..f57ae6e4 100644
--- a/doc/release-notes-33106.md
+++ b/doc/release-notes-33106.md
@@ -9,8 +9,7 @@ changed to 100 satoshis per kvB. They can still be changed using their respectiv
recommended to change both together if you decide to do so.
Other minimum feerates (e.g. the dust feerate, the minimum returned by the fee estimator, and all feerates used by the
-wallet) remain unchanged. The mempool minimum feerate still changes in response to high volume but more gradually, as a
-result of the change to the incremental relay feerate.
+wallet) remain unchanged. The mempool minimum feerate still changes in response to high volume.
Note that unless these lower defaults are widely adopted across the network, transactions created with lower fee rates
are not guaranteed to propagate or confirm. The wallet feerates remain unchanged; `-mintxfee` must be changed before
diff --git a/src/test/miner_tests.cpp b/src/test/miner_tests.cpp
index 156f6e5b..652ec25f 100644
--- a/src/test/miner_tests.cpp
+++ b/src/test/miner_tests.cpp
@@ -218,7 +218,8 @@ void MinerTestingSetup::TestPackageSelection(const CScript& scriptPubKey, const
tx.vout[0].nValue = 5000000000LL - 100000000;
tx.vout[1].nValue = 100000000; // 1BTC output
// Increase size to avoid rounding errors: when the feerate is extremely small (i.e. 1sat/kvB), evaluating the fee
- // at a smaller transaction size gives us a rounded value of 0.
+ // at smaller sizes gives us rounded values that are equal to each other, which means we incorrectly include
+ // hashFreeTx2 + hashLowFeeTx2.
BulkTransaction(tx, 4000);
Txid hashFreeTx2 = tx.GetHash();
AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx));
diff --git a/test/functional/feature_rbf.py b/test/functional/feature_rbf.py
index 6922b5e0..443910c0 100755
--- a/test/functional/feature_rbf.py
+++ b/test/functional/feature_rbf.py
@@ -583,7 +583,7 @@ class ReplaceByFeeTest(BitcoinTestFramework):
tx = self.wallet.send_self_transfer(from_node=self.nodes[0])['tx']
# Higher fee, higher feerate, different txid, but the replacement does not provide a relay
- # fee conforming to node's `incrementalrelayfee` policy of 1000 sat per KB.
+ # fee conforming to node's `incrementalrelayfee` policy of 100 sat per KB.
assert_equal(self.nodes[0].getmempoolinfo()["incrementalrelayfee"], Decimal("0.000001"))
tx.vout[0].nValue -= 1
assert_raises_rpc_error(-26, "insufficient fee", self.nodes[0].sendrawtransaction, tx.serialize().hex())
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.