AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36509: refactor: remove more dead code

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36509: refactor: remove more dead code

570c4a184f49b6d71bc581ae694b969a91cf2510 build: enable -Wunused-macros & -Wunused-template (fanquake)
7981e61764474d914ad7808cac939b821c854495 test: remove unused equal from check_equal() (fanquake)
e8a70c0c68874b153cf02f0b49269ad40302f850 qt: remove unused WalletController::m_options_model (fanquake)
2e23a5b1f1602fb9ff5f6cf659cf1d30c5576dab qt: remove unused AddressBookPage::sendCoins signal (fanquake)
18a5e90179dd0b70b73bef82c0a7aca8c7770f23 qt: remove unused ClientModel::getNumBlocks and its cache (fanquake)
3a3e0ced8c1618f21b662b79902c05df4dc3297a qt: remove unused BitcoinAmountField::setReadOnly (fanquake)
f226197c0015108b3d0f3fd6a3d068275aacefd5 qt: remove unused BitcoinAmountField::SetMaxValue (fanquake)
92ad4ad4042f6ed8b20abe408e713d5e6eea7230 qt: remove unused removeAllWallets (fanquake)
4881802c3f6088f284923003d57ecc7c8a409c41 qt: remove stale PeerTablePriv forward declaration (fanquake)
3f40af467271177abad96426092c03cbb2e231d2 fuzz: remove unused FuzzedWallet::GetScriptPubKey (fanquake)
fc21d18741130aacca21289304da9b6a22eca768 qt: remove unused COLOR_BLACK (fanquake)
830a95548a444a3f1fe86bc26881b290382a5a23 refactor: remove unused ScriptHash(const CScriptID&) constructor (fanquake)
d6ffa22e287a593aec0669860f0b61a9bdaa9262 fuzz: remove unused MockedDescriptorConverter::IdIsXpub (fanquake)
664c2f4600d87cd94100ff03a29cf8178704a678 logging: remove unused Logger::AddCategoryLogLevel (fanquake)
fb7a3aef1bc89cf26af7fee6d5425c3d0689a059 addrman: remove unused AddrMan::Unserialize(AutoFile&) instantiation (fanquake)
54fe34c6b32def9d94692e8f74d56ed12f1acd9d policy: remove unused EXTRA_DESCENDANT_TX_SIZE_LIMIT (fanquake)
71f598018bc8101aaa9f7f496289e43437ea9266 refactor: remove unused BinarySemaphoreGrant alias (fanquake)
a781e4828983b4038fe8c5d98a097d8ade2853dc qt: remove unused TrafficGraphWidget::getGraphRange (fanquake)
8a8a46d7b6164981363dbb185db3a895f4193078 qt: remove unused OptionsDialog::proxyIpChecks signal (fanquake)
2fecbfd1e159f2a5eae6ec8a97da3684ef617110 qt: remove unused QValueComboBox::setRole (fanquake)
50fb338f94e46686d16cc36bfd55fb57d5f116c7 qt: remove unused ClientModel::isReleaseVersion (fanquake)
101345feaa0043caeb79b55f5a6354d85a7b0183 script: remove unused FillableSigningProvider::GetCScripts (fanquake)
5eddbb45c2ad9a293ea0cb796189b794293bc887 ipc: remove unused FooImplementation::passBlockState (fanquake)
159596418166e397fafdbf1e1a090ef0578afd18 test: remove unused GetMockableDatabase declaration (fanquake)
98136193f6b75b82facfda90b46c9d99e0e82932 kernel: remove unused MemPoolLimits::NoLimits (fanquake)
d7c16aa057ecce0743ce2cd79bebf74f757b2dba netbase: remove unused Proxy::GetFamily (fanquake)
d28d1a980999f346eb1994e361c0ecc0dd081d06 span: remove unused MakeWritableUCharSpan (fanquake)

Pull request description:

Part of #36167.

ACKs for top commit:
stickies-v:
ACK 570c4a184f49b6d71bc581ae694b969a91cf2510
sedited:
ACK 570c4a184f49b6d71bc581ae694b969a91cf2510

Tree-SHA512: 2249fe91098006228006b30e4c18b204fb5d6dfefea8d175a2d8ea45409220df5c62c6618125b69e8af3b4f775269c11cf424a429cc3fe93629e961420f8eeec
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit is a routine cleanup that removes unused code, unused compiler warning flags, and stale declarations from Bitcoin Core. None of the changes alter active behavior, fix bugs, or introduce security-sensitive logic. It is purely a refactoring and build-hygiene change.

Recommended action

No security action required. Treat as normal refactoring; standard review and CI testing are sufficient.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.