Revert "build: exclude mptest target from compile commands"
What the developer wrote
Authored by fanquake
Revert "build: exclude mptest target from compile commands"
This reverts commit 4731049ba4f8a820cc4aa13a745e41bdfbee284a.
What changed, and why it matters
This is a tiny build-system revert. It changes one line in a CMake file so that the 'mptest' target is no longer excluded from the generated compile_commands.json database used by developer tools like clang-tidy. There is no indication this affects runtime security, user funds, network consensus, or shipped binaries. It appears to be a developer-quality or tooling fix.
No security action required. Treat as a normal build-system/maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
Commit d186c390 reverts 4731049ba, restoring ‘mptest’ in the EXPORT_COMPILE_COMMANDS OFF property list for libmultiprocess targets. The original commit excluded mptest because generated C++ source files for that target did not exist at compile-command generation time, causing clang-tidy/IWYU complaints. The revert implies an alternate fix was found or the exclusion caused other tooling issues. The change is confined to CMake compile-command generation and does not alter compiled code, runtime behavior, or installed artifacts.
Changed components
cmake/libmultiprocess.cmakelibmultiprocess build toolingcompile_commands.json generationInspect captured patch +1 / −1
diff --git a/cmake/libmultiprocess.cmake b/cmake/libmultiprocess.cmake
index 0dab1f66..027109a9 100644
--- a/cmake/libmultiprocess.cmake
+++ b/cmake/libmultiprocess.cmake
@@ -34,5 +34,5 @@ function(add_libmultiprocess subdir)
# exclusion, tools like clang-tidy and IWYU that make use of compilation
# database would complain that the generated c++ source files do not exist. An
# alternate fix could build "mpexamples" by default like "mptests" above.
- set_target_properties(mpcalculator mpprinter mpexample mptest PROPERTIES EXPORT_COMPILE_COMMANDS OFF)
+ set_target_properties(mpcalculator mpprinter mpexample PROPERTIES EXPORT_COMPILE_COMMANDS OFF)
endfunction()
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.