ci: Properly include $FILE_ENV in DEPENDS_HASH
What the developer wrote
Authored by Ava Chow
ci: Properly include $FILE_ENV in DEPENDS_HASH
$FILE_ENV has a full relative path already, prepending with ci/test/
results in a non-existent path which means that DEPENDS_HASH was not
actually committing to the test's environment file.
What changed, and why it matters
This is a tiny CI (Continuous Integration) configuration fix. The GitHub Actions script was accidentally pointing to the wrong path for an environment file when computing a cache hash. As a result, changes to that environment file would not invalidate the build cache. It is not a vulnerability in Bitcoin Core itself and does not directly put user funds or node security at risk, but it could theoretically cause CI to reuse a stale dependency cache after an environment change.
No urgent action required. Ensure CI cache behavior is monitored after merge to confirm environment file changes now correctly invalidate the DEPENDS cache. Consider reviewing other CI hash computations for similar path mistakes.
Security signals we found
Cache invalidation bypass in CI due to incorrect file path
Potential stale dependency cache reuse after environment file changes
No direct code or cryptographic change in Bitcoin Core
Evidence from the diff
The commit removes an erroneous ‘ci/test/’ prefix from the path used in a git ls-tree command inside .github/actions/configure-environment/action.yml. $FILE_ENV already contains a relative path (likely ‘ci/test/00_setup_env_*.sh’), so prepending ‘ci/test/’ produced a non-existent path. Consequently, DEPENDS_HASH only incorporated the ‘depends’ directory and ignored the environment file, weakening cache invalidation for dependency builds in CI.
Changed components
.github/actions/configure-environment/action.ymlGitHub Actions CI dependency cache hash computationInspect captured patch +1 / −1
diff --git a/.github/actions/configure-environment/action.yml b/.github/actions/configure-environment/action.yml
index aae5016b..e2a26b71 100644
--- a/.github/actions/configure-environment/action.yml
+++ b/.github/actions/configure-environment/action.yml
@@ -17,7 +17,7 @@ runs:
- name: Set cache hashes
shell: bash
run: |
- echo "DEPENDS_HASH=$(git ls-tree HEAD depends "ci/test/$FILE_ENV" | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
+ echo "DEPENDS_HASH=$(git ls-tree HEAD depends "$FILE_ENV" | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
echo "PREVIOUS_RELEASES_HASH=$(git ls-tree HEAD test/get_previous_releases.py | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
- name: Get container name
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.