What the developer wrote
Authored by will
test: speed up feature_dbcrash
What changed, and why it matters
This commit only changes a test script to make it run faster. It swaps one internal test helper for another equivalent one when sending transactions during a crash-recovery test. There is no change to the actual Bitcoin Core software that users run, and no security relevance.
No action required. This is a benign test-only performance improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In test/functional/feature_dbcrash.py, the test replaces self.wallet.send_self_transfer_multi(from_node=node, …) with self.wallet.create_self_transfer_multi(…) followed by node.sendrawtransaction(hexstring=tx[‘hex’], maxfeerate=0). This avoids a wrapper that may perform extra validation or setup, speeding up the functional test. The change is confined to test code and does not alter consensus, networking, wallet, or node behavior.
Changed components
test/functional/feature_dbcrash.pyInspect captured patch +2 / −2
diff --git a/test/functional/feature_dbcrash.py b/test/functional/feature_dbcrash.py
index 6b6c63c4..98aabb8d 100755
--- a/test/functional/feature_dbcrash.py
+++ b/test/functional/feature_dbcrash.py
@@ -196,12 +196,12 @@ class ChainstateWriteCrashTest(BitcoinTestFramework):
# Sanity check -- if we chose inputs that are too small, skip
continue
- self.wallet.send_self_transfer_multi(
- from_node=node,
+ tx = self.wallet.create_self_transfer_multi(
utxos_to_spend=utxos_to_spend,
num_outputs=3,
fee_per_output=FEE // 3,
)
+ node.sendrawtransaction(hexstring=tx["hex"], maxfeerate=0)
num_transactions += 1
def run_test(self):
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.