ci: Rename items specific to Windows + MSVCRT
What the developer wrote
Authored by Hennadii Stepanov
ci: Rename items specific to Windows + MSVCRT
This is necessary to prepare for introducing the new Windows + UCRT
script and jobs.
What changed, and why it matters
This commit only renames CI (Continuous Integration) job names and a configuration script filename to clarify that they are for Windows builds using the older MSVCRT runtime. It does not change any actual build commands, compiler flags, source code, or runtime behavior. There is no security issue here.
No action required. This is a non-security CI maintenance/refactor commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is a pure refactor of GitHub Actions workflow identifiers and a CI environment setup script path. The deleted 00_setup_env_win64.sh and the added 00_setup_env_win64_msvcrt.sh have identical content except for the CONTAINER_NAME value, which is updated to include _msvcrt. Workflow job keys and display names are updated to include msvcrt in preparation for adding a future UCRT variant. No executable code, dependencies, or build configuration are modified.
Changed components
.github/workflows/ci.ymlci/test/00_setup_env_win64_msvcrt.shInspect captured patch +28 / −28
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 880cc90c..60b5583b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -343,14 +343,14 @@ jobs:
run: |
py -3 test/fuzz/test_runner.py --par $NUMBER_OF_PROCESSORS --loglevel DEBUG "${RUNNER_TEMP}/qa-assets/fuzz_corpora"
- windows-cross:
- name: 'Windows-cross to x86_64'
+ windows-msvcrt-cross:
+ name: 'Windows-cross to x86_64, MSVCRT'
needs: runners
runs-on: ${{ needs.runners.outputs.provider == 'cirrus' && 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-sm' || 'ubuntu-24.04' }}
if: ${{ vars.SKIP_BRANCH_PUSH != 'true' || github.event_name == 'pull_request' }}
env:
- FILE_ENV: './ci/test/00_setup_env_win64.sh'
+ FILE_ENV: './ci/test/00_setup_env_win64_msvcrt.sh'
DANGER_CI_ON_HOST_FOLDERS: 1
steps:
@@ -387,10 +387,10 @@ jobs:
${{ env.BASE_BUILD_DIR }}/src/univalue/*.exe
${{ env.BASE_BUILD_DIR }}/test/config.ini
- windows-native-test:
- name: 'Windows, test cross-built'
+ windows-msvcrt-native-test:
+ name: 'Windows, MSVCRT, test cross-built'
runs-on: windows-2022
- needs: windows-cross
+ needs: windows-msvcrt-cross
env:
PYTHONUTF8: 1
diff --git a/ci/test/00_setup_env_win64.sh b/ci/test/00_setup_env_win64.sh
deleted file mode 100755
index 3a349105..00000000
--- a/ci/test/00_setup_env_win64.sh
+++ /dev/null
@@ -1,22 +0,0 @@
-#!/usr/bin/env bash
-#
-# Copyright (c) 2019-present The Bitcoin Core developers
-# Distributed under the MIT software license, see the accompanying
-# file COPYING or http://www.opensource.org/licenses/mit-license.php.
-
-export LC_ALL=C.UTF-8
-
-export CONTAINER_NAME=ci_win64
-export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:24.04" # Check that https://packages.ubuntu.com/noble/g++-mingw-w64-x86-64-posix (version 13.x, similar to guix) can cross-compile
-export HOST=x86_64-w64-mingw32
-export PACKAGES="g++-mingw-w64-x86-64-posix nsis"
-export RUN_UNIT_TESTS=false
-export RUN_FUNCTIONAL_TESTS=false
-export GOAL="deploy"
-export BITCOIN_CONFIG="\
- --preset=dev-mode \
- -DENABLE_IPC=OFF \
- -DWITH_USDT=OFF \
- -DREDUCE_EXPORTS=ON \
- -DCMAKE_CXX_FLAGS='-Wno-error=maybe-uninitialized' \
-"
diff --git a/ci/test/00_setup_env_win64_msvcrt.sh b/ci/test/00_setup_env_win64_msvcrt.sh
new file mode 100755
index 00000000..86e0ea9c
--- /dev/null
+++ b/ci/test/00_setup_env_win64_msvcrt.sh
@@ -0,0 +1,22 @@
+#!/usr/bin/env bash
+#
+# Copyright (c) 2019-present The Bitcoin Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+export LC_ALL=C.UTF-8
+
+export CONTAINER_NAME=ci_win64_msvcrt
+export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:24.04" # Check that https://packages.ubuntu.com/noble/g++-mingw-w64-x86-64-posix (version 13.x, similar to guix) can cross-compile
+export HOST=x86_64-w64-mingw32
+export PACKAGES="g++-mingw-w64-x86-64-posix nsis"
+export RUN_UNIT_TESTS=false
+export RUN_FUNCTIONAL_TESTS=false
+export GOAL="deploy"
+export BITCOIN_CONFIG="\
+ --preset=dev-mode \
+ -DENABLE_IPC=OFF \
+ -DWITH_USDT=OFF \
+ -DREDUCE_EXPORTS=ON \
+ -DCMAKE_CXX_FLAGS='-Wno-error=maybe-uninitialized' \
+"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.