move-only(qa): Move wallet creation check down to others
What the developer wrote
Authored by Hodlinator
move-only(qa): Move wallet creation check down to others
Makes the functions broken out from run_test() in the next commit more cohesive.
What changed, and why it matters
This is a test-only change that moves a single error-checking test case from one place to another within the same functional test file. It does not change any production code, wallet behavior, or security logic. The commit message explicitly calls it 'move-only'.
No action needed. This is a non-functional test refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch is a pure relocation of an existing RPC test assertion in test/functional/wallet_multiwallet.py. Four lines (a createwallet error-path check) were removed from around line 156 and reinserted four lines later under the ‘Test dynamic wallet creation’ section. No code logic, error handling, or behavior was modified.
Changed components
test/functional/wallet_multiwallet.pyInspect captured patch +4 / −4
diff --git a/test/functional/wallet_multiwallet.py b/test/functional/wallet_multiwallet.py
index 86d2737d..cd3ada3a 100755
--- a/test/functional/wallet_multiwallet.py
+++ b/test/functional/wallet_multiwallet.py
@@ -153,10 +153,6 @@ class MultiWalletTest(BitcoinTestFramework):
assert_equal(set(node.listwallets()), set(wallet_names))
- # should raise rpc error if wallet path can't be created
- err_code = -4
- assert_raises_rpc_error(err_code, "filesystem error:" if platform.system() != 'Windows' else "create_directories:", node.createwallet, "w8/bad")
-
# check that all requested wallets were created
self.stop_node(0)
for wallet_name in wallet_names:
@@ -304,6 +300,10 @@ class MultiWalletTest(BitcoinTestFramework):
self.log.info("Test dynamic wallet creation.")
+ # should raise rpc error if wallet path can't be created
+ err_code = -4
+ assert_raises_rpc_error(err_code, "filesystem error:" if platform.system() != 'Windows' else "create_directories:", node.createwallet, "w8/bad")
+
# Fail to create a wallet if it already exists.
path = wallet_dir(node, "w2")
assert_raises_rpc_error(-4, "Failed to create database path '{}'. Database already exists.".format(path), node.createwallet, 'w2')
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.