What the developer wrote
Authored by fanquake
contrib: update makeseeds UA regex
What changed, and why it matters
This commit updates a regular expression in a seed-node generation script so it recognizes newer Bitcoin Core version numbers (28.2 and 29.0) when scanning network peers. It is a routine maintenance change to the list of acceptable user-agent strings and does not alter node consensus, wallet, or network security code.
No security action required; treat as normal project maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is in contrib/seeds/makeseeds.py, a helper script used to produce the hardcoded DNS seed list. It extends the PATTERN_AGENT regex to accept user-agent versions 28.2 and 29.0. There is no modification to P2P protocol handling, validation, mempool, or cryptography.
Changed components
contrib/seeds/makeseeds.pyInspect captured patch +2 / −1
diff --git a/contrib/seeds/makeseeds.py b/contrib/seeds/makeseeds.py
index da6efe70..80de5de3 100755
--- a/contrib/seeds/makeseeds.py
+++ b/contrib/seeds/makeseeds.py
@@ -48,7 +48,8 @@ PATTERN_AGENT = re.compile(
r"|25\.(0|1|2|99)\.0"
r"|26\.(0|1|2|99)\.0"
r"|27\.(0|1|2|99)\.0"
- r"|28\.(0|1|99)\.0"
+ r"|28\.(0|1|2|99)\.0"
+ r"|29\.(0|99)\.0"
r")")
def parseline(line: str) -> Union[dict, None]:
Why this scored 16/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.