AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

coins: avoid moving `COutPoint` values

Public commit record

What the developer wrote

Authored by Lőrinc

68/100 · Adequate
coins: avoid moving `COutPoint` values

`EmplaceCoinInternalDANGER` took `COutPoint&&`, forcing callers to pass trivially copyable outpoints as rvalues even though the cache stores its own key.

Take `outpoint` by const reference and pass existing outpoints directly at all call sites.

Co-authored-by: Andrew Toth <andrewstoth@gmail.com>
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This is a small code cleanup change. It changes one internal function so it accepts a constant reference to an outpoint instead of taking ownership by moving it. Since COutPoint is a tiny, cheap-to-copy object, moving it was unnecessary and forced callers to write extra std::move() calls. The behavior of the program is unchanged; there is no security fix here.

Recommended action

No security action needed. Treat as normal code-quality refactor.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.