Remove unused DEFAULT_ANCESTOR_SIZE_LIMIT_KVB and DEFAULT_DESCENDANT_SIZE_LIMIT_KVB
What the developer wrote
Authored by Suhas Daftuar
Remove unused DEFAULT_ANCESTOR_SIZE_LIMIT_KVB and DEFAULT_DESCENDANT_SIZE_LIMIT_KVB
What changed, and why it matters
This commit simply deletes two unused constant definitions from a header file. These constants were leftover default values for mempool ancestor and descendant size limits. They had no effect on running code because nothing referenced them. There is no security issue.
No action needed. This is a safe dead-code removal.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch removes DEFAULT_ANCESTOR_SIZE_LIMIT_KVB and DEFAULT_DESCENDANT_SIZE_LIMIT_KVB from src/policy/policy.h. The corresponding command-line options -limitancestorsize and -limitdescendantsize are already handled elsewhere with their own defaults, and these specific named constants were not referenced anywhere in the codebase. This is a pure cleanup change with no functional or security impact.
Changed components
src/policy/policy.hInspect captured patch +0 / −4
diff --git a/src/policy/policy.h b/src/policy/policy.h
index 2a15f29c..f3f5ffb7 100644
--- a/src/policy/policy.h
+++ b/src/policy/policy.h
@@ -71,12 +71,8 @@ static constexpr unsigned int DEFAULT_CLUSTER_LIMIT{64};
static constexpr unsigned int DEFAULT_CLUSTER_SIZE_LIMIT_KVB{101};
/** Default for -limitancestorcount, max number of in-mempool ancestors */
static constexpr unsigned int DEFAULT_ANCESTOR_LIMIT{25};
-/** Default for -limitancestorsize, maximum kilobytes of tx + all in-mempool ancestors */
-static constexpr unsigned int DEFAULT_ANCESTOR_SIZE_LIMIT_KVB{101};
/** Default for -limitdescendantcount, max number of in-mempool descendants */
static constexpr unsigned int DEFAULT_DESCENDANT_LIMIT{25};
-/** Default for -limitdescendantsize, maximum kilobytes of in-mempool descendants */
-static constexpr unsigned int DEFAULT_DESCENDANT_SIZE_LIMIT_KVB{101};
/** Default for -datacarrier */
static const bool DEFAULT_ACCEPT_DATACARRIER = true;
/**
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.