AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36152: test: cover the feature-negotiation version boundary in p2p_leak

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36152: test: cover the feature-negotiation version boundary in p2p_leak

2fabbc0bb38d0b87913d16777e25497ee6d017f0 test: check SENDTXRCNCL is sent at version 70016 (brunoerg)
36775471f81ab5ad8499bf0e1c8aab6545db9da6 test: cover the feature-negotiation version boundary in p2p_leak (brunoerg)

Pull request description:

p2p_leak already checks that a pre-wtxidrelay peer (nVersion 70015) is sent neither WTXIDRELAY nor SENDADDRV2, but nothing pins down the exact boundary: the feature negotiation messages are offered when the common version is >= WTXID_RELAY_VERSION (70016).

Add a peer advertising exactly 70016 and assert it receives both messages, so an off-by-one change of either `greatest_common_version >= WTXID_RELAY_VERSION` / `>= 70016` comparison to `>` is detected.

It kills https://bitcoincore.space/src/net_processing.cpp#3462 and https://bitcoincore.space/src/net_processing.cpp#3464

-----

edit: added a commit that adds a test case that checks `SENDTXRCNCL` is sent at version 70016. The existing 70015 case only shows SENDTXRCNCL is withheld below the wtxidrelay version. Add a peer at exactly 70016 so the lower bound of the `>= WTXID_RELAY_VERSION` check is covered too. It kills: https://bitcoincore.space/src/net_processing.cpp#3466.

ACKs for top commit:
Marisha-Sahay:
tACK 2fabbc0bb38d0b87913d16777e25497ee6d017f0
naiyoma:
tACK 2fabbc0bb38d0b87913d16777e25497ee6d017f0
sedited:
ACK 2fabbc0bb38d0b87913d16777e25497ee6d017f0

Tree-SHA512: 33d71176866b317063354880b4b465c9acb2737c7cba931a249faecc86fe30868caabf8cc69001f661163c2db58903ff3655c05a995a3233e9864ebdf2b3b551
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit only adds new test cases to Bitcoin Core's functional test suite. It does not change any production networking code. The tests verify that peers advertising protocol version exactly 70016 receive expected feature-negotiation messages (WTXIDRELAY, SENDADDRV2, and SENDTXRCNCL), pinning down the lower boundary of an existing `>= 70016` check. There is no security vulnerability being fixed here.

Recommended action

No action required. This is a test-coverage improvement. Reviewers may optionally run the updated functional tests to confirm they pass.

Security signals we found

01

No production code modified

02

Only functional test files changed

03

Adds regression coverage for existing version-boundary behavior

04

No bug fix, hardening, or vulnerability remediation present

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.