Fix parameter name in getmempoolcluster rpc
What the developer wrote
Authored by Suhas Daftuar
Fix parameter name in getmempoolcluster rpc
What changed, and why it matters
This is a one-word documentation fix in a Bitcoin Core RPC help message. The error message shown when a user provides an invalid transaction ID now says 'txid' instead of 'parameter 1'. There is no security impact.
No action required; this is a non-security documentation/string fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit changes only the second argument to ParseHashV() in getmempoolcluster. That argument is used solely as a human-readable field name in error/help text when parsing fails. It does not affect parsing logic, validation, memory handling, or authorization.
Changed components
src/rpc/mempool.cppgetmempoolcluster RPCInspect captured patch +1 / −1
diff --git a/src/rpc/mempool.cpp b/src/rpc/mempool.cpp
index 10b8614b..a9a67834 100644
--- a/src/rpc/mempool.cpp
+++ b/src/rpc/mempool.cpp
@@ -695,7 +695,7 @@ static RPCHelpMan getmempoolcluster()
},
[&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
{
- uint256 hash = ParseHashV(request.params[0], "parameter 1");
+ uint256 hash = ParseHashV(request.params[0], "txid");
const CTxMemPool& mempool = EnsureAnyMemPool(request.context);
LOCK(mempool.cs);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.