wallet: remove "RPC Only" from -walletrbf option help description
What changed, and why it matters
This commit is a one-word documentation update. It removes the phrase 'RPC only' from the help text of the -walletrbf command-line option because the feature is now also available through the graphical user interface. There is no code behavior change and no security impact.
No action needed; this is a non-functional documentation string change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change edits a single string in src/wallet/init.cpp used for the -walletrbf option’s help description. It drops ‘(RPC only)’ from the description after GUI support was added in bitcoin-core/gui#936. The ArgsManager registration, option handling, and wallet logic are unchanged.
Changed components
src/wallet/init.cppInspect captured patch +1 / −1
diff --git a/src/wallet/init.cpp b/src/wallet/init.cpp
index d21da2a5..74e433a3 100644
--- a/src/wallet/init.cpp
+++ b/src/wallet/init.cpp
@@ -74,7 +74,7 @@ void WalletInit::AddWalletOptions(ArgsManager& argsman) const
#if HAVE_SYSTEM
argsman.AddArg("-walletnotify=<cmd>", "Execute command when a wallet transaction changes. %s in cmd is replaced by TxID, %w is replaced by wallet name, %b is replaced by the hash of the block including the transaction (set to 'unconfirmed' if the transaction is not included) and %h is replaced by the block height (-1 if not included). %w is not currently implemented on windows. On systems where %w is supported, it should NOT be quoted because this would break shell escaping used to invoke the command.", ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
#endif
- argsman.AddArg("-walletrbf", strprintf("(DEPRECATED) Send transactions with full-RBF opt-in enabled (RPC only, default: %u)", DEFAULT_WALLET_RBF), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
+ argsman.AddArg("-walletrbf", strprintf("(DEPRECATED) Send transactions with full-RBF opt-in enabled (default: %u)", DEFAULT_WALLET_RBF), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET);
argsman.AddArg("-unsafesqlitesync", "Set SQLite synchronous=OFF to disable waiting for the database to sync to disk. This is unsafe and can cause data loss and corruption. This option is only used by tests to improve their performance (default: false)", ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::WALLET_DEBUG_TEST);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.