AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36611: test: consolidate mempool constants

Public commit record

What the developer wrote

Authored by Ryan Ofsky

91/100 · Strong
Merge bitcoin/bitcoin#36611: test: consolidate mempool constants

d8cca0c110b264be0cca69fb4c55ebee0e8152a7 test: use MAX_FUTURE_BLOCK_TIME from blocktools (fanquake)
9ee579b6cba087f2cdd74968b8098806e7510092 test: move DEFAULT_ANCESTOR_LIMIT to mempool_util (fanquake)
8f4caec89590b5bd8804c8f9e01d547f9e51533a test: consolidate DEFAULT_CLUSTER_LIMIT to mempool_util (fanquake)
75a611998e35508b5f90e94f8a77ab6d266e84ab test: add MAX_REPLACEMENT_CANDIDATES to mempool_util (fanquake)
aa7d0a5b582f92cc5be9544be7a0f395646e53c3 test: use TRUC constants from mempool_util (fanquake)

Pull request description:

Consolidate usage of mempool constants in the functional tests.
As well as one instance of `MAX_FUTURE_BLOCK_TIME`.

ACKs for top commit:
stickies-v:
re-ACK d8cca0c110b264be0cca69fb4c55ebee0e8152a7
mercie-ux:
re-ACK https://github.com/bitcoin/bitcoin/commit/d8cca0c110b264be0cca69fb4c55ebee0e8152a7
hodlinator:
re-ACK d8cca0c110b264be0cca69fb4c55ebee0e8152a7

Tree-SHA512: 8399f61e3fcc375863842a6ebae23ef48d38e7a6fc264888b671cc57401277c66f7f31a4aa414619b64e8bafceeb4dd2e3d9585113b221d0a3fe8c44589f8ce9
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit is a test-only cleanup. It moves several hard-coded numbers used in Bitcoin Core's functional tests into a shared helper file so they are defined in one place. No production code, consensus rules, or network behavior were changed.

Recommended action

No security action needed. This is a routine refactoring of test constants.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.