← Watch feed
fees: rename fees_args to block_policy_estimator_args
Public commit record
73/100 · Adequate
What the developer wrote
Authored by ismaelsadeeq
fees: rename fees_args to block_policy_estimator_args
- Also move them to policy/fees/ and update includes
- Note: the block_policy_estimator_args.h include in block_policy_estimator_args.cpp was done manually.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
What changed, and why it matters
This commit is a simple file rename and move. It renames `fees_args` to `block_policy_estimator_args` and moves the files into the `policy/fees/` directory. The actual code inside the files is unchanged, and only include paths are updated in other files. There is no security issue here.
Recommended action
No action required. This is a benign refactoring change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
Pure refactoring commit: src/policy/fees_args.cpp and src/policy/fees_args.h are moved/renamed to src/policy/fees/block_policy_estimator_args.cpp and src/policy/fees/block_policy_estimator_args.h. The CMake build file and all source/test includes are updated accordingly. No functional code changes.
Changed components
src/policy/fees_args.cppsrc/policy/fees_args.hsrc/policy/fees/block_policy_estimator_args.cppsrc/policy/fees/block_policy_estimator_args.hsrc/init.cppsrc/test/fuzz/policy_estimator.cppsrc/test/fuzz/policy_estimator_io.cppsrc/test/policyestimator_tests.cppsrc/CMakeLists.txtInspect captured patch +36 / −36
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index d3fd043d..1b01cb59 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -239,7 +239,7 @@ add_library(bitcoin_node STATIC EXCLUDE_FROM_ALL
noui.cpp
policy/ephemeral_policy.cpp
policy/fees/block_policy_estimator.cpp
- policy/fees_args.cpp
+ policy/fees/block_policy_estimator_args.cpp
policy/packages.cpp
policy/rbf.cpp
policy/settings.cpp
diff --git a/src/init.cpp b/src/init.cpp
index efa27418..a93d3203 100644
--- a/src/init.cpp
+++ b/src/init.cpp
@@ -59,7 +59,7 @@
#include <node/peerman_args.h>
#include <policy/feerate.h>
#include <policy/fees/block_policy_estimator.h>
-#include <policy/fees_args.h>
+#include <policy/fees/block_policy_estimator_args.h>
#include <policy/policy.h>
#include <policy/settings.h>
#include <protocol.h>
diff --git a/src/policy/fees/block_policy_estimator_args.cpp b/src/policy/fees/block_policy_estimator_args.cpp
new file mode 100644
index 00000000..c66b09bf
--- /dev/null
+++ b/src/policy/fees/block_policy_estimator_args.cpp
@@ -0,0 +1,16 @@
+// Copyright (c) 2021 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#include <policy/fees/block_policy_estimator_args.h>
+
+#include <common/args.h>
+
+namespace {
+const char* FEE_ESTIMATES_FILENAME = "fee_estimates.dat";
+} // namespace
+
+fs::path FeeestPath(const ArgsManager& argsman)
+{
+ return argsman.GetDataDirNet() / FEE_ESTIMATES_FILENAME;
+}
diff --git a/src/policy/fees/block_policy_estimator_args.h b/src/policy/fees/block_policy_estimator_args.h
new file mode 100644
index 00000000..f206c667
--- /dev/null
+++ b/src/policy/fees/block_policy_estimator_args.h
@@ -0,0 +1,15 @@
+// Copyright (c) 2022 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#ifndef BITCOIN_POLICY_FEES_BLOCK_POLICY_ESTIMATOR_ARGS_H
+#define BITCOIN_POLICY_FEES_BLOCK_POLICY_ESTIMATOR_ARGS_H
+
+#include <util/fs.h>
+
+class ArgsManager;
+
+/** @return The fee estimates data file path. */
+fs::path FeeestPath(const ArgsManager& argsman);
+
+#endif // BITCOIN_POLICY_FEES_BLOCK_POLICY_ESTIMATOR_ARGS_H
diff --git a/src/policy/fees_args.cpp b/src/policy/fees_args.cpp
deleted file mode 100644
index 988b6d44..00000000
--- a/src/policy/fees_args.cpp
+++ /dev/null
@@ -1,16 +0,0 @@
-// Copyright (c) 2021 The Bitcoin Core developers
-// Distributed under the MIT software license, see the accompanying
-// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-
-#include <policy/fees_args.h>
-
-#include <common/args.h>
-
-namespace {
-const char* FEE_ESTIMATES_FILENAME = "fee_estimates.dat";
-} // namespace
-
-fs::path FeeestPath(const ArgsManager& argsman)
-{
- return argsman.GetDataDirNet() / FEE_ESTIMATES_FILENAME;
-}
diff --git a/src/policy/fees_args.h b/src/policy/fees_args.h
deleted file mode 100644
index ef5cf144..00000000
--- a/src/policy/fees_args.h
+++ /dev/null
@@ -1,15 +0,0 @@
-// Copyright (c) 2022 The Bitcoin Core developers
-// Distributed under the MIT software license, see the accompanying
-// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-
-#ifndef BITCOIN_POLICY_FEES_ARGS_H
-#define BITCOIN_POLICY_FEES_ARGS_H
-
-#include <util/fs.h>
-
-class ArgsManager;
-
-/** @return The fee estimates data file path. */
-fs::path FeeestPath(const ArgsManager& argsman);
-
-#endif // BITCOIN_POLICY_FEES_ARGS_H
diff --git a/src/test/fuzz/policy_estimator.cpp b/src/test/fuzz/policy_estimator.cpp
index 5faa91bb..fee68953 100644
--- a/src/test/fuzz/policy_estimator.cpp
+++ b/src/test/fuzz/policy_estimator.cpp
@@ -4,7 +4,7 @@
#include <kernel/mempool_entry.h>
#include <policy/fees/block_policy_estimator.h>
-#include <policy/fees_args.h>
+#include <policy/fees/block_policy_estimator_args.h>
#include <primitives/transaction.h>
#include <streams.h>
#include <test/fuzz/FuzzedDataProvider.h>
diff --git a/src/test/fuzz/policy_estimator_io.cpp b/src/test/fuzz/policy_estimator_io.cpp
index 89d93f46..3a634124 100644
--- a/src/test/fuzz/policy_estimator_io.cpp
+++ b/src/test/fuzz/policy_estimator_io.cpp
@@ -3,7 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <policy/fees/block_policy_estimator.h>
-#include <policy/fees_args.h>
+#include <policy/fees/block_policy_estimator_args.h>
#include <streams.h>
#include <test/fuzz/FuzzedDataProvider.h>
#include <test/fuzz/fuzz.h>
diff --git a/src/test/policyestimator_tests.cpp b/src/test/policyestimator_tests.cpp
index 689a5b3b..0e1bfec2 100644
--- a/src/test/policyestimator_tests.cpp
+++ b/src/test/policyestimator_tests.cpp
@@ -3,7 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <policy/fees/block_policy_estimator.h>
-#include <policy/fees_args.h>
+#include <policy/fees/block_policy_estimator_args.h>
#include <policy/policy.h>
#include <test/util/txmempool.h>
#include <txmempool.h>
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.