build: remove FALLTHROUGH_INTENDED from leveldb.cmake
What the developer wrote
Authored by fanquake
build: remove FALLTHROUGH_INTENDED from leveldb.cmake
No-longer needed after
https://github.com/bitcoin-core/leveldb-subtree/pull/60.
What changed, and why it matters
This is a routine build cleanup. It removes one compiler-definition line that mapped an old LevelDB macro to the modern C++17 '[[fallthrough]]' attribute. The change is possible because the bundled LevelDB subtree was separately updated to use the modern attribute directly. There is no security-relevant change to runtime behavior.
No action required. This is a benign build-system cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes the CMake compile definition FALLTHROUGH_INTENDED=[[fallthrough]] from cmake/leveldb.cmake. This definition was a compatibility shim for LevelDB’s switch-statement fallthrough annotations. After bitcoin-core/leveldb-subtree#60, LevelDB uses the standard C++17 [[fallthrough]] attribute directly, so the shim is unnecessary. The diff is a single-line build-system removal with no functional code changes.
Changed components
cmake/leveldb.cmakeInspect captured patch +0 / −1
diff --git a/cmake/leveldb.cmake b/cmake/leveldb.cmake
index f69e386e..b9246cf8 100644
--- a/cmake/leveldb.cmake
+++ b/cmake/leveldb.cmake
@@ -56,7 +56,6 @@ target_compile_definitions(leveldb
HAVE_FDATASYNC=$<BOOL:${HAVE_FDATASYNC}>
HAVE_FULLFSYNC=$<BOOL:${HAVE_FULLFSYNC}>
HAVE_O_CLOEXEC=$<BOOL:${HAVE_O_CLOEXEC}>
- FALLTHROUGH_INTENDED=[[fallthrough]]
$<$<NOT:$<BOOL:${WIN32}>>:LEVELDB_PLATFORM_POSIX>
$<$<BOOL:${WIN32}>:LEVELDB_PLATFORM_WINDOWS>
$<$<BOOL:${WIN32}>:_UNICODE;UNICODE>
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.