What the developer wrote
Authored by Hodlinator
rpc: Correct type for tx_sigops
Broken out from larger effort to make CAmount more type safe.
What changed, and why it matters
This commit changes a single variable type in Bitcoin Core's mining RPC code. The variable that holds signature-operation counts for transactions is now declared as a plain integer type (int64_t) instead of the money-amount type (CAmount). The commit message frames this as a type-safety cleanup, not a security fix. There is no direct evidence in the commit or supplied references that this change fixes an exploitable vulnerability.
Treat as a routine code-quality/type-safety improvement. No urgent security action is indicated by the commit itself. If auditing, verify that block_template->getTxSigops() returns a type safely convertible to int64_t and that downstream consumers expect int64_t.
Security signals we found
Type-safety cleanup in RPC mining code
No functional logic change visible in diff
No bounds, validation, or authorization changes
Evidence from the diff
In src/rpc/mining.cpp, the getblocktemplate RPC handler declared tx_sigops as std::vector
Changed components
src/rpc/mining.cppgetblocktemplate RPCInspect captured patch +1 / −1
diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp
index dcf5ee26..2b4745eb 100644
--- a/src/rpc/mining.cpp
+++ b/src/rpc/mining.cpp
@@ -897,7 +897,7 @@ static RPCMethod getblocktemplate()
UniValue transactions(UniValue::VARR);
std::map<Txid, int64_t> setTxIndex;
std::vector<CAmount> tx_fees{block_template->getTxFees()};
- std::vector<CAmount> tx_sigops{block_template->getTxSigops()};
+ std::vector<int64_t> tx_sigops{block_template->getTxSigops()};
int i = 0;
for (const auto& it : block.vtx) {
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.