wallet, test: remove -walletrbf startup option from wallet_backwards_compatibility.py
What the developer wrote
Authored by rkrux
wallet, test: remove -walletrbf startup option from wallet_backwards_compatibility.py
This option can be removed from the previous releases as well because the
default for them is already 1.
What changed, and why it matters
This commit only changes a single test file. It removes the redundant '-walletrbf=1' startup flag from several test nodes because those older Bitcoin Core versions already default to that setting. There is no change to the actual Bitcoin Core wallet or network code, and no security issue is present.
No security action needed. This is a routine test cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies test/functional/wallet_backwards_compatibility.py, dropping ‘-walletrbf=1’ from the extra_args lists for v25.0, v24.0.1, v23.0, v22.0, v0.21.0, and v0.20.1 test nodes. The commit message states this is safe because the default for those releases is already 1. No production code, consensus code, wallet logic, or network behavior is altered.
Changed components
test/functional/wallet_backwards_compatibility.pyInspect captured patch +6 / −6
diff --git a/test/functional/wallet_backwards_compatibility.py b/test/functional/wallet_backwards_compatibility.py
index af50bcdb..6ac9c9e9 100755
--- a/test/functional/wallet_backwards_compatibility.py
+++ b/test/functional/wallet_backwards_compatibility.py
@@ -39,12 +39,12 @@ class BackwardsCompatibilityTest(BitcoinTestFramework):
self.extra_args = [
["-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # Pre-release: use to mine blocks. noban for immediate tx relay
["-nowallet", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # Pre-release: use to receive coins, swap wallets, etc
- ["-nowallet", "-walletrbf=1", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # v25.0
- ["-nowallet", "-walletrbf=1", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # v24.0.1
- ["-nowallet", "-walletrbf=1", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # v23.0
- ["-nowallet", "-walletrbf=1", "-addresstype=bech32", "-whitelist=noban@127.0.0.1", f"-keypool={LAST_KEYPOOL_INDEX + 1}"], # v22.0
- ["-nowallet", "-walletrbf=1", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # v0.21.0
- ["-nowallet", "-walletrbf=1", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # v0.20.1
+ ["-nowallet", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # v25.0
+ ["-nowallet", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # v24.0.1
+ ["-nowallet", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # v23.0
+ ["-nowallet", "-addresstype=bech32", "-whitelist=noban@127.0.0.1", f"-keypool={LAST_KEYPOOL_INDEX + 1}"], # v22.0
+ ["-nowallet", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # v0.21.0
+ ["-nowallet", "-addresstype=bech32", "-whitelist=noban@127.0.0.1"], # v0.20.1
]
self.wallet_names = [self.default_wallet_name]
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.