Merge bitcoin/bitcoin#36579: refactor: Enable some string performance tidy rules
What changed, and why it matters
This commit is a routine code cleanup that turns on three clang-tidy style checks and applies the resulting mechanical fixes. It replaces multi-character string literals like " " and "\n" with single characters where a single character is enough, and removes a few unnecessary std::string conversions. The changes are purely about code style and tiny performance gains (the author reports roughly 0.3% fewer CPU instructions in one benchmark). There is no security bug being fixed and no new attack surface introduced.
No security action needed. Treat as a normal refactoring/CI cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The merge enables three clang-tidy performance rules—performance-faster-string-find, performance-prefer-single-char-overloads, and performance-string-view-conversions—and applies the automated fixes across 21 files. The diff is entirely composed of: (1) replacing std::string += “x” with += ‘x’ for single-character appends, (2) using char literals in starts_with/find-style calls, and (3) removing redundant std::string{} wrappers around string literals passed to functions taking std::string_view or const std::string&. These are compile-time/style refactorings with no semantic change to consensus, networking, wallet, or RPC logic.
Changed components
src/.clang-tidy configurationCLI/bitcoind startup help text formattingRPC help/example string formattingDescriptor and wallet descriptor string formattingUniValue JSON serialization formattingQt RPC console parsingUnit tests onlyInspect captured patch +63 / −66
### src/.clang-tidy
@@ -23,12 +23,9 @@ modernize-use-starts-ends-with,
performance-*,
-performance-avoid-endl,
-performance-enum-size,
--performance-faster-string-find,
-performance-inefficient-string-concatenation,
-performance-no-int-to-ptr,
-performance-noexcept-move-constructor,
--performance-prefer-single-char-overloads,
--performance-string-view-conversions,
-performance-unnecessary-value-param,
-performance-use-std-move,
readability-avoid-const-params-in-decls,
### src/bitcoin-cli.cpp
@@ -1444,7 +1444,7 @@ static void ParseGetInfoResult(UniValue& result)
if (ibd_progress < 0.99) {
GetProgressBar(ibd_progress, ibd_progress_bar);
// Add padding between progress bar and IBD progress
- ibd_progress_bar += " ";
+ ibd_progress_bar += ' ';
}
result_string += strprintf("Verification progress: %s%.4f%%\n", ibd_progress_bar, ibd_progress * 100);
@@ -1510,7 +1510,7 @@ static void ParseGetInfoResult(UniValue& result)
result["balances"][wallet].getValStr(),
wallet.empty() ? "\"\"" : wallet);
}
- result_string += "\n";
+ result_string += '\n';
}
const std::string warnings{result["warnings"].getValStr()};
### src/bitcoin.cpp
@@ -139,7 +139,7 @@ CommandLine ParseCommandLine(int argc, char* argv[])
cmd.show_version = true;
} else if (arg == "-h" || arg == "--help" || arg == "help") {
cmd.show_help = true;
- } else if (arg.starts_with("-")) {
+ } else if (arg.starts_with('-')) {
throw std::runtime_error(strprintf("Unknown option: %s", arg));
} else if (!arg.empty()) {
cmd.command = arg;
### src/bitcoind.cpp
@@ -140,10 +140,10 @@ static bool ProcessInitCommands(interfaces::Init& init, ArgsManager& args)
if (HelpRequested(args) || args.GetBoolArg("-version", false)) {
std::string strUsage = CLIENT_NAME " daemon version " + FormatFullVersion();
if (const char* exe_name{init.exeName()}) {
- strUsage += " ";
+ strUsage += ' ';
strUsage += exe_name;
}
- strUsage += "\n";
+ strUsage += '\n';
if (args.GetBoolArg("-version", false)) {
strUsage += FormatParagraph(LicenseInfo());
### src/core_io.cpp
@@ -364,7 +364,7 @@ std::string ScriptToAsmStr(const CScript& script, const bool fAttemptSighashDeco
CScript::const_iterator pc = script.begin();
while (pc < script.end()) {
if (!str.empty()) {
- str += " ";
+ str += ' ';
}
if (!script.GetOp(pc, opcode, vch)) {
str += "[error]";
### src/logging.cpp
@@ -369,7 +369,7 @@ std::string BCLog::Logger::GetLogPrefix(BCLog::LogFlags category, BCLog::Level l
// If there is a category, Debug is implied, so don't add the level
// Only add separator if we have a category
- if (has_category) s += ":";
+ if (has_category) s += ':';
s += Logger::LogLevelToStr(level);
}
### src/primitives/transaction.cpp
@@ -48,7 +48,7 @@ std::string CTxIn::ToString() const
str += strprintf(", scriptSig=%s", HexStr(scriptSig).substr(0, 24));
if (nSequence != SEQUENCE_FINAL)
str += strprintf(", nSequence=%u", nSequence);
- str += ")";
+ str += ')';
return str;
}
### src/qt/rpcconsole.cpp
@@ -189,7 +189,7 @@ bool RPCConsole::RPCParseCommandLine(interfaces::Node* node, std::string &strRes
std::string strCommandTerminated = strCommand;
if (strCommandTerminated.back() != '\n')
- strCommandTerminated += "\n";
+ strCommandTerminated += '\n';
for (chpos = 0; chpos < strCommandTerminated.size(); ++chpos)
{
char ch = strCommandTerminated[chpos];
### src/qt/test/rpcnestedtests.cpp
@@ -64,13 +64,13 @@ void RPCNestedTests::rpcNestedTests()
RPCConsole::RPCExecuteCommandLine(m_node, result, "getblock( getblock( getblock(getbestblockhash())[hash] )[hash], true)"); //4 level nesting with whitespace, filtering path and boolean parameter
RPCConsole::RPCExecuteCommandLine(m_node, result, "getblockchaininfo");
- QVERIFY(result.starts_with("{"));
+ QVERIFY(result.starts_with('{'));
RPCConsole::RPCExecuteCommandLine(m_node, result, "getblockchaininfo()");
- QVERIFY(result.starts_with("{"));
+ QVERIFY(result.starts_with('{'));
RPCConsole::RPCExecuteCommandLine(m_node, result, "getblockchaininfo "); //whitespace at the end will be tolerated
- QVERIFY(result.starts_with("{"));
+ QVERIFY(result.starts_with('{'));
RPCConsole::RPCExecuteCommandLine(m_node, result, "getblockchaininfo()[\"chain\"]"); //Quote path identifier are allowed, but look after a child containing the quotes in the key
QVERIFY(result == "null");
### src/rpc/server.cpp
@@ -110,7 +110,7 @@ std::string CRPCTable::help(std::string_view strCommand, const JSONRPCRequest& h
if (category != pcmd->category)
{
if (!category.empty())
- strRet += "\n";
+ strRet += '\n';
category = pcmd->category;
strRet += "== " + Capitalize(category) + " ==\n";
}
### src/rpc/util.cpp
@@ -200,7 +200,7 @@ std::string HelpExampleCliNamed(const std::string& methodname, const RPCArgList&
: argpair.second.write();
result += " " + argpair.first + "=" + ShellQuoteIfNeeded(value);
}
- result += "\n";
+ result += '\n';
return result;
}
@@ -473,7 +473,7 @@ struct Sections {
} else {
left += push_name ? arg.ToStringObj(/*oneline=*/false) : arg.ToString(/*oneline=*/false);
}
- left += ",";
+ left += ',';
PushSection({left, arg.ToDescriptionString(/*is_named_arg=*/push_name)});
break;
}
@@ -493,7 +493,7 @@ struct Sections {
case RPCArg::Type::ARR: {
auto left = indent;
left += push_name ? "\"" + arg.GetName() + "\": " : "";
- left += "[";
+ left += '[';
const auto right = is_top_level_arg ? "" : arg.ToDescriptionString(/*is_named_arg=*/push_name);
PushSection({left, right});
for (const auto& arg_inner : arg.m_inner) {
@@ -519,7 +519,7 @@ struct Sections {
CHECK_NONFATAL(s.m_left.find('\n') == std::string::npos);
if (s.m_right.empty()) {
ret += s.m_left;
- ret += "\n";
+ ret += '\n';
continue;
}
@@ -544,7 +544,7 @@ struct Sections {
new_line_pos = s.m_right.find_first_of('\n', begin + 1);
}
ret += right;
- ret += "\n";
+ ret += '\n';
}
return ret;
}
@@ -787,7 +787,7 @@ std::string RPCMethod::ToString() const
for (const auto& arg : m_args) {
if (arg.m_opts.hidden) break; // Any arg that follows is also hidden
const bool optional = arg.IsOptional();
- ret += " ";
+ ret += ' ';
if (optional) {
if (!was_optional) ret += "( ";
was_optional = true;
@@ -942,7 +942,7 @@ bool RPCArg::IsOptional() const
std::string RPCArg::ToDescriptionString(bool is_named_arg) const
{
std::string ret;
- ret += "(";
+ ret += '(';
if (m_opts.type_str.size() != 0) {
ret += m_opts.type_str.at(1);
} else {
@@ -997,7 +997,7 @@ std::string RPCArg::ToDescriptionString(bool is_named_arg) const
}
} // no default case, so the compiler can warn about missing cases
}
- ret += ")";
+ ret += ')';
if (m_type == Type::OBJ_NAMED_PARAMS) ret += " Options object that can be used to pass named arguments, listed below.";
ret += m_description.empty() ? "" : " " + m_description;
return ret;
@@ -1231,7 +1231,7 @@ void RPCResult::CheckInnerDoc() const
std::string RPCArg::ToStringObj(const bool oneline) const
{
std::string res;
- res += "\"";
+ res += '\"';
res += GetFirstName();
if (oneline) {
res += "\":";
@@ -1252,7 +1252,7 @@ std::string RPCArg::ToStringObj(const bool oneline) const
case Type::BOOL:
return res + "bool";
case Type::ARR:
- res += "[";
+ res += '[';
for (const auto& i : m_inner) {
res += i.ToString(oneline) + ",";
}
### src/script/descriptor.cpp
@@ -760,10 +760,10 @@ class MuSigPubkeyProvider final : public PubkeyProvider
std::string out = "musig(";
for (size_t i = 0; i < m_participants.size(); ++i) {
const auto& pubkey = m_participants.at(i);
- if (i) out += ",";
+ if (i) out += ',';
out += pubkey->ToString(type);
}
- out += ")";
+ out += ')';
out += FormatHDKeypath(m_path);
if (IsRangedDerivation()) {
out += "/*";
@@ -776,14 +776,14 @@ class MuSigPubkeyProvider final : public PubkeyProvider
out = "musig(";
for (size_t i = 0; i < m_participants.size(); ++i) {
const auto& pubkey = m_participants.at(i);
- if (i) out += ",";
+ if (i) out += ',';
std::string tmp;
if (pubkey->ToPrivateString(arg, tmp)) {
any_privkeys = true;
}
out += tmp;
}
- out += ")";
+ out += ')';
out += FormatHDKeypath(m_path);
if (IsRangedDerivation()) {
out += "/*";
@@ -795,14 +795,14 @@ class MuSigPubkeyProvider final : public PubkeyProvider
out = "musig(";
for (size_t i = 0; i < m_participants.size(); ++i) {
const auto& pubkey = m_participants.at(i);
- if (i) out += ",";
+ if (i) out += ',';
std::string tmp;
if (!pubkey->ToNormalizedString(arg, tmp, cache)) {
return false;
}
out += tmp;
}
- out += ")";
+ out += ')';
out += FormatHDKeypath(m_path);
if (IsRangedDerivation()) {
out += "/*";
@@ -960,7 +960,7 @@ class DescriptorImpl : public Descriptor
// Initialize to true for non-private types.
bool any_success{!is_private};
for (const auto& scriptarg : m_subdescriptor_args) {
- if (pos++) ret += ",";
+ if (pos++) ret += ',';
std::string tmp;
bool subscript_res{scriptarg->ToStringHelper(arg, tmp, type, cache)};
if (!is_private && !subscript_res) return false;
@@ -982,7 +982,7 @@ class DescriptorImpl : public Descriptor
bool any_success{!is_private};
for (const auto& pubkey : m_pubkey_args) {
- if (pos++) ret += ",";
+ if (pos++) ret += ',';
std::string tmp;
switch (type) {
case StringType::NORMALIZED:
### src/test/argsman_tests.cpp
@@ -910,7 +910,7 @@ BOOST_FIXTURE_TEST_CASE(util_ArgsMerge, ArgsMergeTestingSetup)
std::vector<const char*> argv = {"ignored"};
for (auto& arg : args) {
arg.insert(0, "-");
- desc += " ";
+ desc += ' ';
desc += arg;
argv.push_back(arg.c_str());
}
@@ -920,10 +920,10 @@ BOOST_FIXTURE_TEST_CASE(util_ArgsMerge, ArgsMergeTestingSetup)
std::string conf;
for (auto& conf_val : GetValues(conf_actions, section, name, "c")) {
- desc += " ";
+ desc += ' ';
desc += conf_val;
conf += conf_val;
- conf += "\n";
+ conf += '\n';
}
std::istringstream conf_stream(conf);
BOOST_CHECK(parser.ReadConfigStream(conf_stream, "filepath", error));
@@ -956,7 +956,7 @@ BOOST_FIXTURE_TEST_CASE(util_ArgsMerge, ArgsMergeTestingSetup)
desc += parser.GetArg(key, "default");
desc += " |";
for (const auto& arg : parser.GetArgs(key)) {
- desc += " ";
+ desc += ' ';
desc += arg;
}
}
@@ -965,12 +965,12 @@ BOOST_FIXTURE_TEST_CASE(util_ArgsMerge, ArgsMergeTestingSetup)
if (!ignored.empty()) {
desc += " | ignored";
for (const auto& arg : ignored) {
- desc += " ";
+ desc += ' ';
desc += arg;
}
}
- desc += "\n";
+ desc += '\n';
out_sha.Write(MakeUCharSpan(desc));
if (out_file) {
@@ -1045,7 +1045,7 @@ BOOST_FIXTURE_TEST_CASE(util_ChainMerge, ChainMergeTestingSetup)
const char* argstr = arg(action);
if (!argstr) break;
argv.push_back(argstr);
- desc += " ";
+ desc += ' ';
desc += argv.back();
}
std::string error;
@@ -1056,10 +1056,10 @@ BOOST_FIXTURE_TEST_CASE(util_ChainMerge, ChainMergeTestingSetup)
for (Action action : conf_actions) {
const char* argstr = arg(action);
if (!argstr) break;
- desc += " ";
+ desc += ' ';
desc += argstr + 1;
conf += argstr + 1;
- conf += "\n";
+ conf += '\n';
}
std::istringstream conf_stream(conf);
BOOST_CHECK(parser.ReadConfigStream(conf_stream, "filepath", error));
@@ -1072,7 +1072,7 @@ BOOST_FIXTURE_TEST_CASE(util_ChainMerge, ChainMergeTestingSetup)
desc += "error: ";
desc += e.what();
}
- desc += "\n";
+ desc += '\n';
out_sha.Write(MakeUCharSpan(desc));
if (out_file) {
### src/test/miniscript_tests.cpp
@@ -610,9 +610,9 @@ BOOST_AUTO_TEST_CASE(fixed_tests)
std::string ms_str_multi_a{"multi_a(1,"};
for (size_t i = 0; i < 21; ++i) {
ms_str_multi_a += HexStr(g_testdata->pubkeys[i]);
- if (i < 20) ms_str_multi_a += ",";
+ if (i < 20) ms_str_multi_a += ',';
}
- ms_str_multi_a += ")";
+ ms_str_multi_a += ')';
Test(ms_str_multi_a, "?", "2079be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798ac20c6047f9441ed7d6d3045406e95c07cd85c778e4b8cef3ca7abac09b95c709ee5ba20f9308a019258c31049344f85f89d5229b531c845836f99b08601f113bce036f9ba20e493dbf1c10d80f3581e4904930b1404cc6c13900ee0758474fa94abe8c4cd13ba202f8bde4d1a07209355b4a7250a5c5128e88b84bddc619ab7cba8d569b240efe4ba20fff97bd5755eeea420453a14355235d382f6472f8568a18b2f057a1460297556ba205cbdf0646e5db4eaa398f365f2ea7a0e3d419b7e0330e39ce92bddedcac4f9bcba202f01e5e15cca351daff3843fb70f3c2f0a1bdd05e5af888a67784ef3e10a2a01ba20acd484e2f0c7f65309ad178a9f559abde09796974c57e714c35f110dfc27ccbeba20a0434d9e47f3c86235477c7b1ae6ae5d3442d49b1943c2b752a68e2a47e247c7ba20774ae7f858a9411e5ef4246b70c65aac5649980be5c17891bbec17895da008cbba20d01115d548e7561b15c38f004d734633687cf4419620095bc5b0f47070afe85aba20f28773c2d975288bc7d1d205c3748651b075fbc6610e58cddeeddf8f19405aa8ba20499fdf9e895e719cfd64e67f07d38e3226aa7b63678949e6e49b241a60e823e4ba20d7924d4f7d43ea965a465ae3095ff41131e5946f3c85f79e44adbcf8e27e080eba20e60fce93b59e9ec53011aabc21c23e97b2a31369b87a5ae9c44ee89e2a6dec0aba20defdea4cdb677750a420fee807eacf21eb9898ae79b9768766e4faa04a2d4a34ba205601570cb47f238d2b0286db4a990fa0f3ba28d1a319f5e7cf55c2a2444da7ccba202b4ea0a797a443d293ef5cff444f4979f06acfebd7e86d277475656138385b6cba204ce119c96e2fa357200b559b2f7dd5a5f02d5290aff74b03f3e471b273211c97ba20352bbf4a4cdd12564f93fa332ce333301d9ad40271f8107181340aef25be59d5ba519c", TESTMODE_VALID | TESTMODE_NONMAL | TESTMODE_NEEDSIG | TESTMODE_P2WSH_INVALID, 22, 21, {}, {}, 22);
// Since 'd:' is 'u' we can use it directly inside a thresh. But we can't under P2WSH.
Test("thresh(2,dv:older(42),s:pk(025cbdf0646e5db4eaa398f365f2ea7a0e3d419b7e0330e39ce92bddedcac4f9bc),s:pk(03d30199d74fb5a22d47b6e054e2f378cedacffcb89904a61d75d0dbd407143e65))", "?", "7663012ab269687c205cbdf0646e5db4eaa398f365f2ea7a0e3d419b7e0330e39ce92bddedcac4f9bcac937c20d30199d74fb5a22d47b6e054e2f378cedacffcb89904a61d75d0dbd407143e65ac935287", TESTMODE_VALID | TESTMODE_NONMAL | TESTMODE_NEEDSIG | TESTMODE_P2WSH_INVALID, 12, 3, {}, {}, 4);
### src/test/net_tests.cpp
@@ -227,10 +227,10 @@ BOOST_AUTO_TEST_CASE(cnetaddr_basic)
"pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscryd\0wtf.onion", 66}));
// TOR, bogus length
- BOOST_CHECK(!addr.SetSpecial(std::string{"mfrggzak.onion"}));
+ BOOST_CHECK(!addr.SetSpecial("mfrggzak.onion"));
// TOR, invalid base32
- BOOST_CHECK(!addr.SetSpecial(std::string{"mf*g zak.onion"}));
+ BOOST_CHECK(!addr.SetSpecial("mf*g zak.onion"));
// I2P
const char* i2p_addr = "UDHDrtrcetjm5sxzskjyr5ztpeszydbh4dpl3pl4utgqqw2v4jna.b32.I2P";
@@ -258,7 +258,7 @@ BOOST_AUTO_TEST_CASE(cnetaddr_basic)
!addr.SetSpecial("pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscsad.b32.i2p"));
// I2P, invalid base32
- BOOST_CHECK(!addr.SetSpecial(std::string{"tp*szydbh4dp.b32.i2p"}));
+ BOOST_CHECK(!addr.SetSpecial("tp*szydbh4dp.b32.i2p"));
// Internal
addr.SetInternal("esffpp");
### src/test/settings_tests.cpp
@@ -232,12 +232,12 @@ BOOST_FIXTURE_TEST_CASE(Merge, MergeTestingSetup)
desc += GetSetting(settings, network, name, ignore_default_section_config, /*ignore_nonpersistent=*/false, /*get_chain_type=*/false).write();
desc += " |";
for (const auto& s : GetSettingsList(settings, network, name, ignore_default_section_config)) {
- desc += " ";
+ desc += ' ';
desc += s.write();
}
desc += " |";
if (OnlyHasDefaultSectionSetting(settings, network, name)) desc += " ignored";
- desc += "\n";
+ desc += '\n';
out_sha.Write(MakeUCharSpan(desc));
if (out_file) {
### src/test/util_expected_tests.cpp
@@ -89,7 +89,7 @@ BOOST_AUTO_TEST_CASE(expected_error)
BOOST_CHECK_EQUAL(e.error(), "fail");
// modify error
- e.error() += "1";
+ e.error() += '1';
const auto& read{e};
BOOST_CHECK_EQUAL(read.error(), "fail1");
### src/test/util_tests.cpp
@@ -926,7 +926,7 @@ BOOST_AUTO_TEST_CASE(test_FormatSubVersion)
comments.emplace_back("comment1");
std::vector<std::string> comments2;
comments2.emplace_back("comment1");
- comments2.push_back(SanitizeString(std::string("Comment2; .,_?@-; !\"#$%&'()*+/<=>[]\\^`{|}~"), SAFE_CHARS_UA_COMMENT)); // Semicolon is discouraged but not forbidden by BIP-0014
+ comments2.push_back(SanitizeString("Comment2; .,_?@-; !\"#$%&'()*+/<=>[]\\^`{|}~", SAFE_CHARS_UA_COMMENT)); // Semicolon is discouraged but not forbidden by BIP-0014
BOOST_CHECK_EQUAL(FormatSubVersion("Test", 99900, std::vector<std::string>()),std::string("/Test:9.99.0/"));
BOOST_CHECK_EQUAL(FormatSubVersion("Test", 99900, comments),std::string("/Test:9.99.0(comment1)/"));
BOOST_CHECK_EQUAL(FormatSubVersion("Test", 99900, comments2),std::string("/Test:9.99.0(comment1; Comment2; .,_?@-; )/"));
### src/univalue/lib/univalue_write.cpp
@@ -69,48 +69,48 @@ static void indentStr(unsigned int prettyIndent, unsigned int indentLevel, std::
// NOLINTNEXTLINE(misc-no-recursion)
void UniValue::writeArray(unsigned int prettyIndent, unsigned int indentLevel, std::string& s) const
{
- s += "[";
+ s += '[';
if (prettyIndent)
- s += "\n";
+ s += '\n';
for (unsigned int i = 0; i < values.size(); i++) {
if (prettyIndent)
indentStr(prettyIndent, indentLevel, s);
s += values[i].write(prettyIndent, indentLevel + 1);
if (i != (values.size() - 1)) {
- s += ",";
+ s += ',';
}
if (prettyIndent)
- s += "\n";
+ s += '\n';
}
if (prettyIndent)
indentStr(prettyIndent, indentLevel - 1, s);
- s += "]";
+ s += ']';
}
// NOLINTNEXTLINE(misc-no-recursion)
void UniValue::writeObject(unsigned int prettyIndent, unsigned int indentLevel, std::string& s) const
{
- s += "{";
+ s += '{';
if (prettyIndent)
- s += "\n";
+ s += '\n';
for (unsigned int i = 0; i < keys.size(); i++) {
if (prettyIndent)
indentStr(prettyIndent, indentLevel, s);
s += "\"" + json_escape(keys[i]) + "\":";
if (prettyIndent)
- s += " ";
+ s += ' ';
s += values.at(i).write(prettyIndent, indentLevel + 1);
if (i != (values.size() - 1))
- s += ",";
+ s += ',';
if (prettyIndent)
- s += "\n";
+ s += '\n';
}
if (prettyIndent)
indentStr(prettyIndent, indentLevel - 1, s);
- s += "}";
+ s += '}';
}
### src/util/subprocess.h
@@ -1088,7 +1088,7 @@ inline void Popen::execute_process() noexcept(false)
for (auto arg : this->vargs_) {
if (!first_arg) {
- command_line += " ";
+ command_line += ' ';
} else {
first_arg = false;
}
### src/wallet/walletutil.cpp
@@ -48,7 +48,7 @@ WalletDescriptor GenerateWalletDescriptor(const CExtPubKey& master_key, const Ou
}
case OutputType::P2SH_SEGWIT: {
desc_prefix = "sh(wpkh(" + xpub + "/49h";
- desc_suffix += ")";
+ desc_suffix += ')';
break;
}
case OutputType::BECH32: {Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.