test: Suppress another unsolicited `mock_process/*` output
What the developer wrote
Authored by Hennadii Stepanov
test: Suppress another unsolicited `mock_process/*` output
The `mock_process/*` test cases, which serve as helpers for
`system_tests` rather than actual tests, are invoked in a way that
suppresses unsolicited output to stdout or stderr to keep the test
results reproducible.
However, in debug builds, the Windows CRT still prints false-positive
memory leak dumps to stderr.
This change handles this specific case and documents the other
suppressions.
What changed, and why it matters
This is a minor test-only change that adds an extra command-line flag to silence false-positive memory-leak messages from the Windows debug runtime during internal Bitcoin Core tests. It does not change any production code, network behavior, or wallet logic, and it does not fix a security vulnerability.
No security action needed. Treat as normal test-maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies src/test/system_tests.cpp so that the mock_executable() helper passes –detect_memory_leaks=0 when invoking mock_process/* test cases. This prevents the Windows UCRT in debug builds from printing spurious memory-leak diagnostics to stderr, keeping test output deterministic. The change is purely cosmetic/test-hygiene and has no security relevance.
Changed components
src/test/system_tests.cppInspect captured patch +12 / −1
diff --git a/src/test/system_tests.cpp b/src/test/system_tests.cpp
index bd57661b..408666d6 100644
--- a/src/test/system_tests.cpp
+++ b/src/test/system_tests.cpp
@@ -26,7 +26,18 @@ BOOST_FIXTURE_TEST_SUITE(system_tests, BasicTestingSetup)
static std::vector<std::string> mock_executable(std::string name)
{
- return {boost::unit_test::framework::master_test_suite().argv[0], "--log_level=nothing", "--report_level=no", "--run_test=mock_process/" + name};
+ // Invoke the mock_process/* test case with all unsolicited output suppressed.
+ return {
+ boost::unit_test::framework::master_test_suite().argv[0],
+ // Disable false-positive memory leak dumps to stderr
+ // in debug builds when using the Windows UCRT.
+ "--detect_memory_leaks=0",
+ // Disable logging to stdout.
+ "--log_level=nothing",
+ // Disable the test report to stderr.
+ "--report_level=no",
+ "--run_test=mock_process/" + name,
+ };
}
BOOST_AUTO_TEST_CASE(run_command)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.