signals: remove forward-declare for signals
What the developer wrote
Authored by Cory Fields
signals: remove forward-declare for signals
This eases the transition to a replacement signals implementation
What changed, and why it matters
This is a routine code cleanup change. It removes forward declarations of the Boost signals2 library and replaces them with a direct include of a project header named btcsignals.h. There is no functional change to program behavior and no security relevance visible in the diff.
No security action needed. Treat as normal refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes forward-declarations of boost::signals2::connection in two headers and adds #include
Changed components
src/interfaces/handler.hsrc/node/interface_ui.hInspect captured patch +4 / −12
diff --git a/src/interfaces/handler.h b/src/interfaces/handler.h
index b3aebf7e..5de131ee 100644
--- a/src/interfaces/handler.h
+++ b/src/interfaces/handler.h
@@ -5,15 +5,11 @@
#ifndef BITCOIN_INTERFACES_HANDLER_H
#define BITCOIN_INTERFACES_HANDLER_H
+#include <btcsignals.h>
+
#include <functional>
#include <memory>
-namespace boost {
-namespace signals2 {
-class connection;
-} // namespace signals2
-} // namespace boost
-
namespace interfaces {
//! Generic interface for managing an event handler or callback function
diff --git a/src/node/interface_ui.h b/src/node/interface_ui.h
index ce5171bb..8c90bdf4 100644
--- a/src/node/interface_ui.h
+++ b/src/node/interface_ui.h
@@ -6,6 +6,8 @@
#ifndef BITCOIN_NODE_INTERFACE_UI_H
#define BITCOIN_NODE_INTERFACE_UI_H
+#include <btcsignals.h>
+
#include <cstdint>
#include <functional>
#include <string>
@@ -15,12 +17,6 @@ class CBlockIndex;
enum class SynchronizationState;
struct bilingual_str;
-namespace boost {
-namespace signals2 {
-class connection;
-}
-} // namespace boost
-
/** Signals for UI communication. */
class CClientUIInterface
{
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.