ci: Switch to `x64-windows-release` triplet
What the developer wrote
Authored by Hennadii Stepanov
ci: Switch to `x64-windows-release` triplet
This removes the need to patch vcpkg source code to skip debug builds
for dependencies.
What changed, and why it matters
This commit changes how Bitcoin Core's Windows continuous-integration builds select a release-only configuration for vcpkg dependencies. It replaces a workaround that patched vcpkg's source code with a built-in triplet name. There is no security-relevant change to the software users run.
No security action required. Treat as a normal CI maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch removes a CI step that appended set(VCPKG_BUILD_TYPE release) to ${VCPKG_INSTALLATION_ROOT}/triplets/x64-windows.cmake and instead passes -DVCPKG_TARGET_TRIPLET=x64-windows-release to the CMake generate command in .github/ci-windows.py. This is a build-hygiene refactor: it uses an upstream vcpkg triplet rather than mutating the vcpkg tree. The change is confined to CI configuration files and does not alter compiled artifacts, dependency versions, compiler flags, or source code.
Changed components
.github/ci-windows.py.github/workflows/ci.ymlInspect captured patch +2 / −6
diff --git a/.github/ci-windows.py b/.github/ci-windows.py
index e21a7da9..a808812e 100755
--- a/.github/ci-windows.py
+++ b/.github/ci-windows.py
@@ -71,8 +71,8 @@ def generate(ci_type):
"-B",
"build",
"-Werror=dev",
- "--preset",
- "vs2026",
+ "--preset=vs2026",
+ "-DVCPKG_TARGET_TRIPLET=x64-windows-release",
] + GENERATE_OPTIONS[ci_type]
if run(command, check=False).returncode != 0:
print("=== ⚠️ ===")
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 13d1e265..b7d6a2fb 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -253,10 +253,6 @@ jobs:
py -3 --version
bash --version
- - name: Using vcpkg with MSBuild
- run: |
- echo "set(VCPKG_BUILD_TYPE release)" >> "${VCPKG_INSTALLATION_ROOT}/triplets/x64-windows.cmake"
-
- name: Set VCPKG_ROOT
run: |
echo "VCPKG_ROOT=${VCPKG_INSTALLATION_ROOT}" >> "$GITHUB_ENV"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.