test: Enable `system_tests/run_command` "stdin" test on Windows
What the developer wrote
Authored by Hennadii Stepanov
test: Enable `system_tests/run_command` "stdin" test on Windows
What changed, and why it matters
This commit simply removes two lines that previously skipped a test on Windows. The test checks that a helper program can receive data through standard input and echo it back. There is no change to production code, no security fix, and no vulnerability.
No security action needed. This is a routine test-enablement change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff removes a #ifndef WIN32 / #endif guard around an existing unit test in src/test/system_tests.cpp. The test invokes RunCommandParseJSON with mock_executable(“pass_stdin_to_stdout”) and verifies JSON round-tripping via stdin. No implementation code is modified; only test coverage is broadened to include Windows.
Changed components
src/test/system_tests.cppInspect captured patch +0 / −2
diff --git a/src/test/system_tests.cpp b/src/test/system_tests.cpp
index c5eac1cb..5f88490e 100644
--- a/src/test/system_tests.cpp
+++ b/src/test/system_tests.cpp
@@ -74,7 +74,6 @@ BOOST_AUTO_TEST_CASE(run_command)
// Unable to parse JSON
BOOST_CHECK_EXCEPTION(RunCommandParseJSON(mock_executable("invalid_json")), std::runtime_error, HasReason("Unable to parse JSON: {"));
}
-#ifndef WIN32
{
// Test stdin
const UniValue result = RunCommandParseJSON(mock_executable("pass_stdin_to_stdout"), "{\"success\": true}");
@@ -83,7 +82,6 @@ BOOST_AUTO_TEST_CASE(run_command)
BOOST_CHECK(!success.isNull());
BOOST_CHECK_EQUAL(success.get_bool(), true);
}
-#endif
}
#endif // ENABLE_EXTERNAL_SIGNER
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.