ci: Tolerate unused free functions in intermediate commits
What the developer wrote
Authored by Fabian Jahr
ci: Tolerate unused free functions in intermediate commits
When bigger changes are split across multiple commits, intermediate
commits may introduce unused functions. Do not check for this error
in intermediate commits.
What changed, and why it matters
This commit changes a CI (Continuous Integration) script used during Bitcoin Core's automated testing. It adds a compiler warning suppression for 'unused free functions' in addition to the existing suppression for 'unused member functions'. This only affects how intermediate commits in a pull request are validated, not the actual Bitcoin software that users run. There is no security issue here.
No security action needed. This is a normal CI/developer workflow change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies .github/ci-test-each-commit-exec.py, which executes tests on each commit in a pull request. It expands -DCMAKE_CXX_FLAGS from suppressing only -Werror=unused-member-function to also suppressing -Werror=unused-function. This is a developer-experience change to allow larger refactorings to be split across multiple commits without CI failing on intermediate states where a newly introduced free function is not yet called. It does not change compiled binaries, consensus code, networking, wallet logic, or any runtime behavior.
Changed components
.github/ci-test-each-commit-exec.pyInspect captured patch +2 / −2
diff --git a/.github/ci-test-each-commit-exec.py b/.github/ci-test-each-commit-exec.py
index aed1526b..402e7352 100755
--- a/.github/ci-test-each-commit-exec.py
+++ b/.github/ci-test-each-commit-exec.py
@@ -40,8 +40,8 @@ def main():
"-DCMAKE_BUILD_TYPE=Debug",
"-DCMAKE_COMPILE_WARNING_AS_ERROR=ON",
"--preset=dev-mode",
- # Tolerate unused member functions in intermediate commits in a pull request
- "-DCMAKE_CXX_FLAGS=-Wno-error=unused-member-function",
+ # Tolerate unused (member) functions in intermediate commits in a pull request
+ "-DCMAKE_CXX_FLAGS=-Wno-error=unused-member-function -Wno-error=unused-function",
])
if run(["cmake", "--build", build_dir, "-j", str(num_procs)], check=False).returncode != 0:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.