Improve comments for getTransactionAncestry to reference cluster counts instead of descendants
What the developer wrote
Authored by Suhas Daftuar
Improve comments for getTransactionAncestry to reference cluster counts instead of descendants
What changed, and why it matters
This commit only changes two comment lines in a header file. It renames 'descendants' to 'cluster_count' in documentation to match what the code actually calculates. No executable code, logic, or behavior was changed, so there is no security impact.
No action required; this is a non-functional documentation-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies only comments in src/interfaces/chain.h for the getTransactionAncestry interface. It updates the descriptive comment and the parameter name in the declaration’s documentation from ‘descendants’ to ‘cluster_count’. No implementation, calling code, or semantics are altered.
Changed components
src/interfaces/chain.hInspect captured patch +2 / −2
diff --git a/src/interfaces/chain.h b/src/interfaces/chain.h
index 2b1d953e..40291d20 100644
--- a/src/interfaces/chain.h
+++ b/src/interfaces/chain.h
@@ -221,8 +221,8 @@ public:
node::TxBroadcast broadcast_method,
std::string& err_string) = 0;
- //! Calculate mempool ancestor and descendant counts for the given transaction.
- virtual void getTransactionAncestry(const Txid& txid, size_t& ancestors, size_t& descendants, size_t* ancestorsize = nullptr, CAmount* ancestorfees = nullptr) = 0;
+ //! Calculate mempool ancestor and cluster counts for the given transaction.
+ virtual void getTransactionAncestry(const Txid& txid, size_t& ancestors, size_t& cluster_count, size_t* ancestorsize = nullptr, CAmount* ancestorfees = nullptr) = 0;
//! For each outpoint, calculate the fee-bumping cost to spend this outpoint at the specified
// feerate, including bumping its ancestors. For example, if the target feerate is 10sat/vbyte
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.