macdeploy: rename macOS output to bitcoin-macos-app.zip
What the developer wrote
Authored by fanquake
macdeploy: rename macOS output to bitcoin-macos-app.zip
We were naming this "Bitcoin-Core.zip", just to immediately rename it.
Similar to what we do with Windows, i.e `bitcoin-win64-setup.exe`.
What changed, and why it matters
This commit simply renames the macOS release ZIP file from 'Bitcoin-Core.zip' to 'bitcoin-macos-app.zip' before it gets its final distribution name. It is a build-system cleanup with no security relevance.
No security action needed; routine build hygiene change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change updates two build scripts (cmake/module/Maintenance.cmake and contrib/guix/libexec/build.sh) so the intermediate macOS app bundle ZIP is consistently named ‘bitcoin-macos-app.zip’ instead of being derived from CLIENT_NAME (‘Bitcoin Core’) and then renamed later. No code behavior, cryptography, networking, or consensus logic is modified.
Changed components
cmake/module/Maintenance.cmakecontrib/guix/libexec/build.shInspect captured patch +9 / −9
diff --git a/cmake/module/Maintenance.cmake b/cmake/module/Maintenance.cmake
index 57c3a794..7f29bc94 100644
--- a/cmake/module/Maintenance.cmake
+++ b/cmake/module/Maintenance.cmake
@@ -96,19 +96,19 @@ function(add_macos_deploy_target)
VERBATIM
)
- string(REPLACE " " "-" osx_volname ${CLIENT_NAME})
+ set(macos_zip "bitcoin-macos-app")
if(CMAKE_HOST_APPLE)
add_custom_command(
- OUTPUT ${PROJECT_BINARY_DIR}/${osx_volname}.zip
- COMMAND Python3::Interpreter ${PROJECT_SOURCE_DIR}/contrib/macdeploy/macdeployqtplus ${macos_app} -translations-dir=${QT_TRANSLATIONS_DIR} -zip=${osx_volname}
+ OUTPUT ${PROJECT_BINARY_DIR}/${macos_zip}.zip
+ COMMAND Python3::Interpreter ${PROJECT_SOURCE_DIR}/contrib/macdeploy/macdeployqtplus ${macos_app} -translations-dir=${QT_TRANSLATIONS_DIR} -zip=${macos_zip}
DEPENDS ${PROJECT_BINARY_DIR}/${macos_app}/Contents/MacOS/Bitcoin-Qt
VERBATIM
)
add_custom_target(deploydir
- DEPENDS ${PROJECT_BINARY_DIR}/${osx_volname}.zip
+ DEPENDS ${PROJECT_BINARY_DIR}/${macos_zip}.zip
)
add_custom_target(deploy
- DEPENDS ${PROJECT_BINARY_DIR}/${osx_volname}.zip
+ DEPENDS ${PROJECT_BINARY_DIR}/${macos_zip}.zip
)
else()
add_custom_command(
@@ -128,13 +128,13 @@ function(add_macos_deploy_target)
)
else()
add_custom_command(
- OUTPUT ${PROJECT_BINARY_DIR}/dist/${osx_volname}.zip
+ OUTPUT ${PROJECT_BINARY_DIR}/dist/${macos_zip}.zip
WORKING_DIRECTORY dist
- COMMAND ${PROJECT_SOURCE_DIR}/cmake/script/macos_zip.sh ${ZIP_EXECUTABLE} ${osx_volname}.zip
+ COMMAND ${PROJECT_SOURCE_DIR}/cmake/script/macos_zip.sh ${ZIP_EXECUTABLE} ${macos_zip}.zip
VERBATIM
)
add_custom_target(deploy
- DEPENDS ${PROJECT_BINARY_DIR}/dist/${osx_volname}.zip
+ DEPENDS ${PROJECT_BINARY_DIR}/dist/${macos_zip}.zip
)
endif()
endif()
diff --git a/contrib/guix/libexec/build.sh b/contrib/guix/libexec/build.sh
index 2b47e164..2fa03d0d 100755
--- a/contrib/guix/libexec/build.sh
+++ b/contrib/guix/libexec/build.sh
@@ -369,7 +369,7 @@ mkdir -p "$DISTSRC"
;;
*darwin*)
cmake --build build --target deploy ${V:+--verbose}
- mv build/dist/Bitcoin-Core.zip "${OUTDIR}/${DISTNAME}-${HOST}-unsigned.zip"
+ mv build/dist/bitcoin-macos-app.zip "${OUTDIR}/${DISTNAME}-${HOST}-unsigned.zip"
mkdir -p "unsigned-app-${HOST}"
cp --target-directory="unsigned-app-${HOST}" \
contrib/macdeploy/detached-sig-create.sh
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.