build: `lockedpool.cpp` kernel -> crypto
What the developer wrote
Authored by David Gumberg
build: `lockedpool.cpp` kernel -> crypto
Allows `crypto` functions and classes to use `secure_allocator`.
What changed, and why it matters
This commit is a pure build-system refactor: it moves the file `lockedpool.cpp` from the `kernel` and `util` libraries into the `crypto` library. The change is organizational only and does not alter any code behavior. It is not a security fix and does not introduce a vulnerability.
No security action needed. Treat as a normal build refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The CMake build files are updated so that support/lockedpool.cpp is compiled as part of bitcoin_crypto instead of bitcoinkernel and bitcoin_util. The stated purpose is to let crypto functions/classes use secure_allocator. No source code in lockedpool.cpp or its consumers is modified, so runtime semantics are unchanged. This is a dependency-graph adjustment with no security-relevant diff evidence.
Changed components
src/crypto/CMakeLists.txtsrc/kernel/CMakeLists.txtsrc/util/CMakeLists.txtInspect captured patch +1 / −2
diff --git a/src/crypto/CMakeLists.txt b/src/crypto/CMakeLists.txt
index 92653ade..4dc84664 100644
--- a/src/crypto/CMakeLists.txt
+++ b/src/crypto/CMakeLists.txt
@@ -20,6 +20,7 @@ add_library(bitcoin_crypto STATIC EXCLUDE_FROM_ALL
sha512.cpp
siphash.cpp
../support/cleanse.cpp
+ ../support/lockedpool.cpp
)
target_link_libraries(bitcoin_crypto
diff --git a/src/kernel/CMakeLists.txt b/src/kernel/CMakeLists.txt
index 244f0098..cf2a0c04 100644
--- a/src/kernel/CMakeLists.txt
+++ b/src/kernel/CMakeLists.txt
@@ -54,7 +54,6 @@ add_library(bitcoinkernel
../script/solver.cpp
../signet.cpp
../streams.cpp
- ../support/lockedpool.cpp
../sync.cpp
../txdb.cpp
../txgraph.cpp
diff --git a/src/util/CMakeLists.txt b/src/util/CMakeLists.txt
index fdf0081c..3444fb09 100644
--- a/src/util/CMakeLists.txt
+++ b/src/util/CMakeLists.txt
@@ -33,7 +33,6 @@ add_library(bitcoin_util STATIC EXCLUDE_FROM_ALL
../random.cpp
../randomenv.cpp
../streams.cpp
- ../support/lockedpool.cpp
../sync.cpp
)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.