test: Fix a STRICTENC test in script_tests
What the developer wrote
Authored by billymcbip
test: Fix a STRICTENC test in script_tests
Fix a test that isn't implemented as intended. The idea is to test execution order by providing a signature that would cause script failure when parsed. An empty signature does not cause script failure in CHECKMULTISIG. Use OP_1 for the second signature instead of OP_0.
What changed, and why it matters
This is a one-line fix to a Bitcoin Core unit test file. The test was not exercising what its author intended because an empty signature does not trigger the expected script failure in a CHECKMULTISIG operation. The change replaces an empty second signature with a non-empty one so the test actually checks the intended execution-order behavior. It does not change any production code, consensus rules, or network behavior.
No action required; this is a test-only correction. Reviewers may optionally verify the new test vector behaves as described and that no other test vectors have similar intent-vs-implementation mismatches.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In src/test/data/script_tests.json, a single test vector for a 2-of-2 CHECKMULTISIG NOT under STRICTENC was corrected. The original vector pushed OP_0 as the second signature, which does not cause a parse failure during CHECKMULTISIG evaluation; the updated vector pushes OP_1 so the second signature is non-empty and will be parsed/validated, exercising the intended early-exit behavior when the first public key fails to validate the first signature. This is purely a test-data correction.
Changed components
src/test/data/script_tests.jsonInspect captured patch +1 / −1
diff --git a/src/test/data/script_tests.json b/src/test/data/script_tests.json
index 43e40dce..3616cf72 100644
--- a/src/test/data/script_tests.json
+++ b/src/test/data/script_tests.json
@@ -698,7 +698,7 @@
"2-of-2 CHECKMULTISIG NOT with the second pubkey invalid, and both signatures validly encoded. Valid pubkey fails, and CHECKMULTISIG exits early, prior to evaluation of second invalid pubkey."
],
[
- "0 0 0x47 0x3044022044dc17b0887c161bb67ba9635bf758735bdde503e4b0a0987f587f14a4e1143d022009a215772d49a85dae40d8ca03955af26ad3978a0ff965faa12915e9586249a501",
+ "0 1 0x47 0x3044022044dc17b0887c161bb67ba9635bf758735bdde503e4b0a0987f587f14a4e1143d022009a215772d49a85dae40d8ca03955af26ad3978a0ff965faa12915e9586249a501",
"2 0x21 0x02865c40293a680cb9c020e7b1e106d8c1916d3cef99aa431a56d253e69256dac0 0x21 0x02865c40293a680cb9c020e7b1e106d8c1916d3cef99aa431a56d253e69256dac0 2 CHECKMULTISIG NOT",
"STRICTENC", "OK",
"2-of-2 CHECKMULTISIG NOT with both pubkeys valid, but second signature invalid. Valid pubkey fails, and CHECKMULTISIG exits early, prior to evaluation of second invalid signature."
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.