test: remove appveyor reference in comment
What the developer wrote
Authored by Max Edwards
test: remove appveyor reference in comment
Appveyor is not longer used however the test still requires to check for
permissions including 666 as otherwise the tests fail on Windows
What changed, and why it matters
This commit only updates two comments in a test file. It replaces the word 'Appveyor' (an old Windows continuous-integration service) with 'Windows' to reflect that the project no longer uses Appveyor. No actual code behavior changes, and there is no security relevance.
No action needed. This is a non-functional comment-only cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is purely cosmetic: two commented-out and one active assertion lines in test/functional/tool_wallet.py now say ‘# Sanity check. 666 on Windows.’ instead of ‘# Sanity check. 666 because Appveyor.’ The permission checks themselves (allowing ‘666’ on Windows) remain identical. No executable logic, configuration, or dependency was modified.
Changed components
test/functional/tool_wallet.pyInspect captured patch +2 / −2
diff --git a/test/functional/tool_wallet.py b/test/functional/tool_wallet.py
index 9255b261..ecef5e13 100755
--- a/test/functional/tool_wallet.py
+++ b/test/functional/tool_wallet.py
@@ -158,7 +158,7 @@ class ToolWalletTest(BitcoinTestFramework):
#
# self.log.debug('Setting wallet file permissions to 400 (read-only)')
# os.chmod(self.wallet_path, stat.S_IRUSR)
- # assert self.wallet_permissions() in ['400', '666'] # Sanity check. 666 because Appveyor.
+ # assert self.wallet_permissions() in ['400', '666'] # Sanity check. 666 on Windows.
# shasum_before = self.wallet_shasum()
timestamp_before = self.wallet_timestamp()
self.log.debug('Wallet file timestamp before calling info: {}'.format(timestamp_before))
@@ -169,7 +169,7 @@ class ToolWalletTest(BitcoinTestFramework):
self.log_wallet_timestamp_comparison(timestamp_before, timestamp_after)
self.log.debug('Setting wallet file permissions back to 600 (read/write)')
os.chmod(self.wallet_path, stat.S_IRUSR | stat.S_IWUSR)
- assert self.wallet_permissions() in ['600', '666'] # Sanity check. 666 because Appveyor.
+ assert self.wallet_permissions() in ['600', '666'] # Sanity check. 666 on Windows.
#
# TODO: Wallet tool info should not write to the wallet file.
# The following lines should be uncommented and the tests still succeed:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.