ci: Use path with spaces on windows as well
What the developer wrote
Authored by MarcoFalke
ci: Use path with spaces on windows as well
What changed, and why it matters
This change only updates Bitcoin Core's internal Windows CI (continuous integration) scripts to run tests inside a temporary folder whose name contains spaces. It is a testing-infrastructure tweak with no effect on the Bitcoin software users run, on network consensus, or on wallets.
No security action needed. Treat as a normal CI/maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies .github/ci-windows-cross.py and .github/ci-windows.py to append ‘/ ’ to the –tmpdirprefix path passed to the functional test runner. This makes CI exercise code paths that handle directories containing spaces on Windows. The diff is purely CI configuration; no runtime, consensus, P2P, RPC, or wallet code is changed.
Changed components
.github/ci-windows-cross.py.github/ci-windows.pyInspect captured patch +2 / −2
diff --git a/.github/ci-windows-cross.py b/.github/ci-windows-cross.py
index 6453cb9e..bf13f81a 100755
--- a/.github/ci-windows-cross.py
+++ b/.github/ci-windows-cross.py
@@ -96,7 +96,7 @@ def run_functional_tests():
"--jobs",
num_procs,
"--quiet",
- f"--tmpdirprefix={workspace}",
+ f"--tmpdirprefix={workspace / '_ _'}",
"--combinedlogslen=99999999",
*shlex.split(os.environ.get("TEST_RUNNER_EXTRA", "").strip()),
# feature_unsupported_utxo_db.py fails on Windows because of emojis in the test data directory.
diff --git a/.github/ci-windows.py b/.github/ci-windows.py
index 964558a2..00acf715 100755
--- a/.github/ci-windows.py
+++ b/.github/ci-windows.py
@@ -198,7 +198,7 @@ def run_tests(ci_type):
"--jobs",
num_procs,
"--quiet",
- f"--tmpdirprefix={workspace}",
+ f"--tmpdirprefix={workspace / '_ _'}",
"--combinedlogslen=99999999",
*shlex.split(os.environ.get("TEST_RUNNER_EXTRA", "").strip()),
]
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.