test: Move Fetching-print to download_from_url util
What the developer wrote
Authored by MarcoFalke
test: Move Fetching-print to download_from_url util
This does not change any behavior.
What changed, and why it matters
This is a harmless test-only code cleanup. It moves a status print statement from one test helper script into another shared test utility, with no change to what the program actually does. There is no security relevance.
No action required. This is a non-security refactoring change in test code.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit refactors test infrastructure in Bitcoin Core. The ‘Fetching:
Changed components
test/download_utils.pytest/get_previous_releases.pyInspect captured patch +1 / −2
diff --git a/test/download_utils.py b/test/download_utils.py
index de7de82c..a4f94d8d 100644
--- a/test/download_utils.py
+++ b/test/download_utils.py
@@ -9,6 +9,7 @@ import urllib.request
def download_from_url(url, archive):
+ print(f"Fetching: {url}")
last_print_time = time.time()
def progress_hook(progress_bytes, total_size):
diff --git a/test/get_previous_releases.py b/test/get_previous_releases.py
index bd83c787..cd77c55e 100755
--- a/test/get_previous_releases.py
+++ b/test/get_previous_releases.py
@@ -129,8 +129,6 @@ def download_binary(tag, args) -> int:
archive = f'bitcoin-{tag[1:]}-{host}.{archive_format}'
archive_url = f'https://bitcoincore.org/{bin_path}/{archive}'
- print(f'Fetching: {archive_url}')
-
try:
download_from_url(archive_url, archive)
except Exception as e:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.