What the developer wrote
Authored by Hodlinator
refactor(qa): Remove unused option
Last use was removed in 0d32d661481f099af572e7a08a50e17bcc165c44.
What changed, and why it matters
This commit simply removes an unused command-line option from a single test script. It is a cleanup change with no effect on Bitcoin Core's runtime behavior, network security, or user funds.
No security action needed. Treat as routine test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes the add_options method from test/functional/wallet_multiwallet.py, which previously defined a --data_wallets_dir argument. The commit message states the option’s last use was removed in an earlier commit (0d32d661481f099af572e7a08a50e17bcc165c44). This is a pure test-code refactor with no functional or security changes.
Changed components
test/functional/wallet_multiwallet.pyInspect captured patch +0 / −7
diff --git a/test/functional/wallet_multiwallet.py b/test/functional/wallet_multiwallet.py
index 07bd7cb2..bdc7f1ac 100755
--- a/test/functional/wallet_multiwallet.py
+++ b/test/functional/wallet_multiwallet.py
@@ -50,13 +50,6 @@ class MultiWalletTest(BitcoinTestFramework):
def skip_test_if_missing_module(self):
self.skip_if_no_wallet()
- def add_options(self, parser):
- parser.add_argument(
- '--data_wallets_dir',
- default=os.path.join(os.path.dirname(os.path.realpath(__file__)), 'data/wallets/'),
- help='Test data with wallet directories (default: %(default)s)',
- )
-
def run_test(self):
node = self.nodes[0]
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.