ci: Enable bitcoin-chainstate and test_bitcoin-qt in win64 task
What the developer wrote
Authored by MarcoFalke
ci: Enable bitcoin-chainstate and test_bitcoin-qt in win64 task
Base the task on --preset=dev-mode to ensure maximal coverage and add
the following:
bitcoin-chainstate (experimental) ... ON
test_bitcoin-qt ..................... ON
IPC and USDT remain explicitly disabled.
What changed, and why it matters
This commit only changes Bitcoin Core's continuous integration (CI) settings for Windows builds. It turns on two extra test executables in the automated build/test pipeline and renames a CI job. There is no change to the actual Bitcoin node, wallet, or network code that users run, so it does not create a security vulnerability or fix one.
No security action needed. Treat as a normal CI/test coverage change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies .github/workflows/ci.yml and ci/test/00_setup_env_win64.sh. It renames the ‘windows-cross’ CI job, adds *.dll artifacts to the upload list, switches the Windows cross-build to –preset=dev-mode, explicitly disables IPC and USDT, and removes the previous -DBUILD_GUI_TESTS=OFF and -DBUILD_KERNEL_LIB=ON -DBUILD_KERNEL_TEST=ON flags (which are now covered by the dev-mode preset). This is a build-system/test-coverage change only.
Changed components
Bitcoin Core CI configurationWindows cross-compilation CI taskInspect captured patch +7 / −2
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 3655a019..52e77997 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -331,7 +331,7 @@ jobs:
py -3 test/fuzz/test_runner.py --par $NUMBER_OF_PROCESSORS --loglevel DEBUG "${RUNNER_TEMP}/qa-assets/fuzz_corpora"
windows-cross:
- name: 'Linux->Windows cross, no tests'
+ name: 'Windows-cross to x86_64'
needs: runners
runs-on: ${{ needs.runners.outputs.provider == 'cirrus' && 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-sm' || 'ubuntu-24.04' }}
if: ${{ vars.SKIP_BRANCH_PUSH != 'true' || github.event_name == 'pull_request' }}
@@ -366,6 +366,7 @@ jobs:
with:
name: x86_64-w64-mingw32-executables-${{ github.run_id }}
path: |
+ ${{ env.BASE_BUILD_DIR }}/bin/*.dll
${{ env.BASE_BUILD_DIR }}/bin/*.exe
${{ env.BASE_BUILD_DIR }}/src/secp256k1/bin/*.exe
${{ env.BASE_BUILD_DIR }}/src/univalue/*.exe
diff --git a/ci/test/00_setup_env_win64.sh b/ci/test/00_setup_env_win64.sh
index 110db1a8..3a349105 100755
--- a/ci/test/00_setup_env_win64.sh
+++ b/ci/test/00_setup_env_win64.sh
@@ -13,6 +13,10 @@ export PACKAGES="g++-mingw-w64-x86-64-posix nsis"
export RUN_UNIT_TESTS=false
export RUN_FUNCTIONAL_TESTS=false
export GOAL="deploy"
-export BITCOIN_CONFIG="-DREDUCE_EXPORTS=ON -DBUILD_GUI_TESTS=OFF -DBUILD_KERNEL_LIB=ON -DBUILD_KERNEL_TEST=ON \
+export BITCOIN_CONFIG="\
+ --preset=dev-mode \
+ -DENABLE_IPC=OFF \
+ -DWITH_USDT=OFF \
+ -DREDUCE_EXPORTS=ON \
-DCMAKE_CXX_FLAGS='-Wno-error=maybe-uninitialized' \
"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.