AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

policy: remove constant parameter from `IsWellFormedPackage`

Public commit record

What the developer wrote

Authored by Lőrinc

91/100 · Strong
policy: remove constant parameter from `IsWellFormedPackage`

`IsWellFormedPackage()` already claims: "parents must appear before children."
In practice the `require_sorted` argument was always passed as `true`, making the false-path dead code.
It was introduced that way from the beginning in https://github.com/bitcoin/bitcoin/pull/28758/files#diff-f30090b30c9489972ee3f1181c302cf3a484bb890bade0fd7c9ca92ea8d347f6R79.

Remove the unused parameter, updating callers/tests.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a small code cleanup change in Bitcoin Core. It removes an unused option from a function that checks whether a group of transactions (a 'package') is properly ordered. The option was always set to 'true' everywhere it was used, so the code path for 'false' was never reachable. The change simplifies the function and its tests but does not alter actual behavior or fix any security issue.

Recommended action

No security action required. Treat as normal code maintenance/refactoring.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.