ci: Remove upstreamed vcpkg workaround
What the developer wrote
Authored by Hennadii Stepanov
ci: Remove upstreamed vcpkg workaround
See https://github.com/microsoft/vcpkg/pull/44712.
What changed, and why it matters
This commit removes a temporary build-system workaround for the Windows CI pipeline. The workaround forced an older CMake compatibility setting when compiling a dependency (libevent) through the vcpkg package manager. Microsoft has now fixed the underlying issue upstream, so Bitcoin Core no longer needs the local override. There is no change to Bitcoin Core's runtime code, consensus rules, wallet handling, or network behavior.
No security action required. Treat as routine CI maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change deletes a sed command in .github/workflows/ci.yml that prepended set(ENV{CMAKE_POLICY_VERSION_MINIMUM} 3.5) to vcpkg’s scripts/ports.cmake. This was a CI-only workaround for libevent’s CMake version requirement being incompatible with CMake 4.x. The referenced upstream vcpkg PR (microsoft/vcpkg#44712) has resolved the incompatibility, making the local override unnecessary. The diff affects only GitHub Actions Windows build configuration.
Changed components
.github/workflows/ci.ymlWindows CI vcpkg/MSBuild jobInspect captured patch +0 / −2
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 914b29ca..13d1e265 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -256,8 +256,6 @@ jobs:
- name: Using vcpkg with MSBuild
run: |
echo "set(VCPKG_BUILD_TYPE release)" >> "${VCPKG_INSTALLATION_ROOT}/triplets/x64-windows.cmake"
- # Workaround for libevent, which requires CMake 3.1 but is incompatible with CMake >= 4.0.
- sed -i '1s/^/set(ENV{CMAKE_POLICY_VERSION_MINIMUM} 3.5)\n/' "${VCPKG_INSTALLATION_ROOT}/scripts/ports.cmake"
- name: Set VCPKG_ROOT
run: |
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.