Merge bitcoin/bitcoin#36425: guix: declare python-setuptools in codesign manifest
What changed, and why it matters
This is a build-system maintenance patch for Bitcoin Core's Guix codesigning environment. It explicitly adds python-setuptools (which Python 3.12 no longer includes by default) and updates a certificate-validation library used during the release signing process. There is no direct vulnerability in the shipped Bitcoin Core software; the change prevents release-build failures and keeps the signing toolchain working.
No urgent action required for node operators or wallet users. For release engineers, ensure the Guix codesigning build is re-run with this manifest and verify reproducible build attestations. Monitor upstream certvalidator/elfesteem for the noted test-loader patch so the temporary workaround can be reverted.
Security signals we found
Build-toolchain dependency update
Explicit declaration of previously implicit build dependency (setuptools)
No change to runtime consensus, P2P, or wallet logic
Patch references upstream certvalidator/elfesteem compatibility work
Fixes an issue (#36421) that broke the Guix codesign build
Evidence from the diff
The commit updates contrib/guix/manifest_codesign.scm to (1) import and declare python-setuptools as a native input for two custom Guix packages (python-oscrypto and python-certvalidator) because Python 3.12 removed implicit setuptools, (2) bump python-certvalidator to a newer upstream commit, and (3) set OSCRYPTO_USE_OPENSSL so the certvalidator test suite can locate OpenSSL libraries. This only affects the reproducible-build codesigning manifest, not consensus, networking, or wallet code.
Changed components
contrib/guix/manifest_codesign.scmGuix codesigning build environmentpython-certvalidator Guix package definitionpython-oscrypto Guix package definitionInspect captured patch +10 / −4
### contrib/guix/manifest_codesign.scm
@@ -2,7 +2,7 @@
((gnu packages compression) #:select (gzip zip))
((gnu packages crypto) #:select (osslsigncode))
((gnu packages nss) #:select (nss-certs))
- ((gnu packages python-build) #:select (python-poetry-core))
+ ((gnu packages python-build) #:select (python-poetry-core python-setuptools))
((gnu packages python-crypto) #:select (python-asn1crypto python-oscrypto))
((gnu packages tls) #:select (openssl))
((gnu packages version-control) #:select (git-minimal))
@@ -28,6 +28,7 @@
(base32
"07x6p8clh11z8s1n2kdxrqwqm2almgc5qpkcr9ckb6y5ivjdr5r6"))))
(build-system python-build-system)
+ (native-inputs (list python-setuptools))
;; There are no tests, but attempting to run python setup.py test leads to
;; PYTHONPATH problems, just disable the test
(arguments '(#:tests? #f))
@@ -51,7 +52,7 @@
#t)))))))
(define-public python-certvalidator
- (let ((commit "a145bf25eb75a9f014b3e7678826132efbba6213"))
+ (let ((commit "8ccb2d334a2ce572395d8e01d0cd2b966f20e626"))
(package
(name "python-certvalidator")
(version (git-version "0.1" "1" commit))
@@ -64,8 +65,9 @@
(file-name (git-file-name name commit))
(sha256
(base32
- "1qw2k7xis53179lpqdqyylbcmp76lj7sagp883wmxg5i7chhc96k"))))
+ "0i7zxjcrj83rklw064979qb0vj053q749md4sx4nyvvra1950is2"))))
(build-system python-build-system)
+ (native-inputs (list python-setuptools))
(propagated-inputs
(list openssl
python-asn1crypto
@@ -108,7 +110,11 @@
line)))
#t))
(replace 'check
- (lambda _
+ (lambda* (#:key inputs #:allow-other-keys)
+ (let ((openssl (assoc-ref inputs "openssl")))
+ (setenv "OSCRYPTO_USE_OPENSSL"
+ (string-append openssl "/lib/libcrypto.so,"
+ openssl "/lib/libssl.so")))
(invoke "python" "run.py" "tests")
#t)))))
(home-page "https://github.com/wbond/certvalidator")Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.