doc: p2p: replace last remaining "command" terminology with "message type"
What changed, and why it matters
This commit only renames the word 'command' to 'message type' in comments and a debug log string. It is a documentation cleanup with no functional code changes and no security impact.
No action required. This is a non-functional documentation-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies two files: src/net_processing.cpp and src/node/protocol_version.h. In net_processing.cpp, two comments and one LogDebug() format string are updated from ‘command’ to ‘message type’. In protocol_version.h, two comments are updated similarly. No executable logic, protocol behavior, parsing, validation, or network handling is changed.
Changed components
src/net_processing.cppsrc/node/protocol_version.hInspect captured patch +5 / −5
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
index 6ec55256..84063f49 100644
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -4945,8 +4945,8 @@ void PeerManagerImpl::ProcessMessage(CNode& pfrom, const std::string& msg_type,
return;
}
- // Ignore unknown commands for extensibility
- LogDebug(BCLog::NET, "Unknown command \"%s\" from peer=%d\n", SanitizeString(msg_type), pfrom.GetId());
+ // Ignore unknown message types for extensibility
+ LogDebug(BCLog::NET, "Unknown message type \"%s\" from peer=%d", SanitizeString(msg_type), pfrom.GetId());
return;
}
@@ -5301,7 +5301,7 @@ void PeerManagerImpl::MaybeSendPing(CNode& node_to, Peer& peer, std::chrono::mic
peer.m_ping_nonce_sent = nonce;
MakeAndPushMessage(node_to, NetMsgType::PING, nonce);
} else {
- // Peer is too old to support ping command with nonce, pong will never arrive.
+ // Peer is too old to support ping message type with nonce, pong will never arrive.
peer.m_ping_nonce_sent = 0;
MakeAndPushMessage(node_to, NetMsgType::PING);
}
diff --git a/src/node/protocol_version.h b/src/node/protocol_version.h
index 43c1bf6c..7904086f 100644
--- a/src/node/protocol_version.h
+++ b/src/node/protocol_version.h
@@ -20,7 +20,7 @@ static const int MIN_PEER_PROTO_VERSION = 31800;
//! BIP 0031, pong message, is enabled for all versions AFTER this one
static const int BIP0031_VERSION = 60000;
-//! "sendheaders" command and announcing blocks with headers starts with this version
+//! "sendheaders" message type and announcing blocks with headers starts with this version
static const int SENDHEADERS_VERSION = 70012;
//! "feefilter" tells peers to filter invs to you by fee starts with this version
@@ -32,7 +32,7 @@ static const int SHORT_IDS_BLOCKS_VERSION = 70014;
//! not banning for invalid compact blocks starts with this version
static const int INVALID_CB_NO_BAN_VERSION = 70015;
-//! "wtxidrelay" command for wtxid-based relay starts with this version
+//! "wtxidrelay" message type for wtxid-based relay starts with this version
static const int WTXID_RELAY_VERSION = 70016;
#endif // BITCOIN_NODE_PROTOCOL_VERSION_H
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.