test: make TestChain100Setup's m_clock timestamp more readable
What the developer wrote
Authored by Hao Xu
test: make TestChain100Setup's m_clock timestamp more readable
The timestamp 1598887952 is used as the initial value of the node's
mocked wall-clock in TestChain100Setup. Comment its UTC date to make
the magic number more readable.
What changed, and why it matters
This commit only adds a comment next to an existing test-only timestamp to explain what date it represents. It does not change any code behavior and has no security relevance.
No action required; this is a non-functional documentation-only change in test infrastructure.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is a single-line comment addition in src/test/util/setup_common.h, annotating the existing mock wall-clock timestamp 1598887952 as ‘2020-08-31, arbitrary’. The FakeNodeClock initialization and all surrounding code remain identical; no logic, constants, or runtime behavior were modified.
Changed components
src/test/util/setup_common.hInspect captured patch +1 / −1
diff --git a/src/test/util/setup_common.h b/src/test/util/setup_common.h
index 72a3a620..d03f5bae 100644
--- a/src/test/util/setup_common.h
+++ b/src/test/util/setup_common.h
@@ -227,7 +227,7 @@ struct TestChain100Setup : public TestingSetup {
*/
std::vector<CTransactionRef> PopulateMempool(FastRandomContext& det_rand, size_t num_transactions, bool submit);
- FakeNodeClock m_clock{std::chrono::seconds{1598887952}};
+ FakeNodeClock m_clock{std::chrono::seconds{1598887952}}; // 2020-08-31, arbitrary
std::vector<CTransactionRef> m_coinbase_txns; // For convenience, coinbase transactions
CKey coinbaseKey; // private/public key needed to spend coinbase transactions
};
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.