What the developer wrote
Authored by Anthony Towns
IWYU fixes
Add missing includes of logging.h in preparation for the next commit,
switching to util/log.h. Also removes some unnecessary util/check.h
includes that CI complains about.
What changed, and why it matters
This commit is a routine code cleanup. It adds missing header file includes for logging and removes one unnecessary include. There is no functional code change and no security issue.
No action required; this is a benign refactoring commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit performs ‘Include What You Use’ (IWYU) maintenance: it adds #include
Changed components
src/bitcoind.cppsrc/signet.cppsrc/test/fuzz/pcp.cppsrc/test/node_init_tests.cppsrc/zmq/zmqutil.cppInspect captured patch +3 / −2
diff --git a/src/bitcoind.cpp b/src/bitcoind.cpp
index ac731587..debc7845 100644
--- a/src/bitcoind.cpp
+++ b/src/bitcoind.cpp
@@ -16,6 +16,7 @@
#include <interfaces/chain.h>
#include <interfaces/init.h>
#include <kernel/context.h>
+#include <logging.h>
#include <node/context.h>
#include <node/interface_ui.h>
#include <node/warnings.h>
diff --git a/src/signet.cpp b/src/signet.cpp
index d0f8aa28..c37ea52f 100644
--- a/src/signet.cpp
+++ b/src/signet.cpp
@@ -13,7 +13,6 @@
#include <script/script.h>
#include <streams.h>
#include <uint256.h>
-#include <util/check.h>
#include <util/log.h>
#include <algorithm>
diff --git a/src/test/fuzz/pcp.cpp b/src/test/fuzz/pcp.cpp
index 4f1faa98..a656d443 100644
--- a/src/test/fuzz/pcp.cpp
+++ b/src/test/fuzz/pcp.cpp
@@ -8,6 +8,7 @@
#include <test/fuzz/util/net.h>
#include <common/pcp.h>
+#include <logging.h>
#include <util/check.h>
#include <util/threadinterrupt.h>
diff --git a/src/test/node_init_tests.cpp b/src/test/node_init_tests.cpp
index 44635dd4..fb9bce6c 100644
--- a/src/test/node_init_tests.cpp
+++ b/src/test/node_init_tests.cpp
@@ -4,6 +4,7 @@
#include <init.h>
#include <interfaces/init.h>
+#include <logging.h>
#include <rpc/server.h>
#include <boost/test/unit_test.hpp>
diff --git a/src/zmq/zmqutil.cpp b/src/zmq/zmqutil.cpp
index 7f28f5e5..f491988c 100644
--- a/src/zmq/zmqutil.cpp
+++ b/src/zmq/zmqutil.cpp
@@ -5,7 +5,6 @@
#include <zmq/zmqutil.h>
#include <logging.h>
-#include <util/check.h>
#include <zmq.h>
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.