AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36432: wallet: show real fee_reason strings in help

Public commit record

What the developer wrote

Authored by merge-script

81/100 · Strong
Merge bitcoin/bitcoin#36432: wallet: show real fee_reason strings in help

781d8dbd500d4f7b6577ed4b37d1d913c25052af wallet: show real fee_reason strings in help (Jehudi Castro-Sierra)

Pull request description:

The verbose help for sendtoaddress and sendmany paraphrased
fee_reason and left out "User Specified Fee". The strings the RPC
returns are the ones in StringForFeeReason.

Join that map for both help lines, the same way estimate_mode help
is built from FeeModeMap, so the list cannot drift again.

wallet_basic.py checks that an explicit fee_rate returns
"User Specified Fee" for sendtoaddress and sendmany.

ACKs for top commit:
maflcko:
lgtm ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af
ismaelsadeeq:
Code review ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af
sedited:
ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af

Tree-SHA512: 83a8cc240dffeab5b01cb54f146b38e63499f893163ae4c6ee184e23e658ea054c5a7e28cc12e02e15c084352808b3a4eefe4a96216accead9010163d529d0da
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This change only updates the help text shown by two wallet RPC commands (sendtoaddress and sendmany) so the list of possible fee reasons matches the actual strings returned by the software. It also adds a test to confirm that an explicit fee rate returns the string 'User Specified Fee'. There is no security issue here—just a documentation/help-text consistency fix.

Recommended action

No security action needed. This is a routine documentation/help-text improvement with added regression test.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.