build: remove -Wno-conditional-uninitialized from leveldb build
What the developer wrote
Authored by fanquake
build: remove -Wno-conditional-uninitialized from leveldb build
What changed, and why it matters
This commit removes a compiler warning suppression from the LevelDB build settings in Bitcoin Core. It does not change any executable code, only build configuration. The change means the compiler may now warn about variables that could be used before being initialized in the bundled LevelDB library. By itself, this is a code-quality cleanup, not a fix for a known security bug.
No immediate action required. Treat as routine build hygiene. If security concern remains, audit LevelDB source for actual uninitialized-variable usage rather than relying on this commit as a fix.
Security signals we found
Compiler warning suppression removed for potentially-uninitialized-variable diagnostic
No source-code change or bug fix present in the diff
No vendor statement of security relevance in commit message
Evidence from the diff
The diff deletes a try_append_cxx_flags block that previously added -Wconditional-uninitialized and, if the compiler accepted it, suppressed it with -Wno-conditional-uninitialized for the nowarn_leveldb_interface target. Removing the suppression allows the compiler to emit -Wconditional-uninitialized diagnostics for LevelDB. There is no source-code change, no patch to any uninitialized-variable bug, and no claim in the commit that a vulnerability was fixed.
Changed components
cmake/leveldb.cmakeLevelDB build configuration in Bitcoin CoreInspect captured patch +0 / −3
diff --git a/cmake/leveldb.cmake b/cmake/leveldb.cmake
index cff8c61f..f69e386e 100644
--- a/cmake/leveldb.cmake
+++ b/cmake/leveldb.cmake
@@ -84,9 +84,6 @@ if(MSVC)
_CRT_NONSTDC_NO_WARNINGS
)
else()
- try_append_cxx_flags("-Wconditional-uninitialized" TARGET nowarn_leveldb_interface SKIP_LINK
- IF_CHECK_PASSED "-Wno-conditional-uninitialized"
- )
try_append_cxx_flags("-Wcovered-switch-default" TARGET nowarn_leveldb_interface SKIP_LINK
IF_CHECK_PASSED "-Wno-covered-switch-default"
)
Why this scored 11/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.