build: Move CMAKE_SKIP_INSTALL_RPATH from CMake to Guix script
What the developer wrote
Authored by Henry Romp
build: Move CMAKE_SKIP_INSTALL_RPATH from CMake to Guix script
Remove CMAKE_SKIP_INSTALL_RPATH from CMakeLists.txt and add CMAKE_SKIP_RPATH to the Guix build script. This keeps build-environment-specific settings in the build scripts rather than hardcoded in the CMake configuration.
What changed, and why it matters
This commit moves a build setting that controls whether executable files remember where to find shared libraries. Previously it was hardcoded in the main CMake configuration; now it is set only in the Guix reproducible-build script. This is a build-system hygiene change with no apparent security effect.
No security action required. Treat as a normal build-system refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change removes CMAKE_SKIP_INSTALL_RPATH TRUE from CMakeLists.txt and adds CMAKE_SKIP_RPATH TRUE to the Guix build script’s CONFIGFLAGS. RPATH/RUNPATH entries tell the dynamic loader where to look for shared libraries. CMAKE_SKIP_RPATH skips both build and install RPATH generation, while the removed CMAKE_SKIP_INSTALL_RPATH only skipped install RPATH. For the Guix deterministic build environment this is functionally equivalent or stricter, and for other build environments it now allows CMake’s default RPATH behavior. There is no code change affecting consensus, networking, wallet, or runtime behavior.
Changed components
CMake build configurationGuix reproducible build scriptInspect captured patch +1 / −2
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4c10fb73..c50e2f6d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -630,7 +630,6 @@ if(CMAKE_SYSTEM_NAME STREQUAL "NetBSD")
set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
else()
set(CMAKE_SKIP_BUILD_RPATH TRUE)
- set(CMAKE_SKIP_INSTALL_RPATH TRUE)
endif()
add_subdirectory(test)
add_subdirectory(doc)
diff --git a/contrib/guix/libexec/build.sh b/contrib/guix/libexec/build.sh
index f23133fd..e3d0ee78 100755
--- a/contrib/guix/libexec/build.sh
+++ b/contrib/guix/libexec/build.sh
@@ -206,7 +206,7 @@ mkdir -p "$OUTDIR"
###########################
# CONFIGFLAGS
-CONFIGFLAGS="-DREDUCE_EXPORTS=ON -DBUILD_BENCH=OFF -DBUILD_GUI_TESTS=OFF -DBUILD_FUZZ_BINARY=OFF"
+CONFIGFLAGS="-DREDUCE_EXPORTS=ON -DBUILD_BENCH=OFF -DBUILD_GUI_TESTS=OFF -DBUILD_FUZZ_BINARY=OFF -DCMAKE_SKIP_RPATH=TRUE"
# CFLAGS
HOST_CFLAGS="-O2 -g"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.